Address code review

Author: corona10

Modules/_testcapi/immortal.c

@@ -1,86 +1,62 @@
 #include "parts.h"
 
-static PyObject*
+static PyObject *
 test_immortal_bool(PyObject *self, PyObject *Py_UNUSED(ignored))
 {
     PyObject* objects[] = {Py_True, Py_False};
     Py_ssize_t n = Py_ARRAY_LENGTH(objects);
-    for(Py_ssize_t i = 0; i < n; i++) {
+    for (Py_ssize_t i = 0; i < n; i++) {
         PyObject* obj = objects[i];
-        if (!_Py_IsImmortal(obj)) {
-            PyErr_Format(PyExc_RuntimeError, "%R should be the immportal object.", obj);
-            return NULL;
-        }
+        assert(_Py_IsImmortal(obj));
         Py_ssize_t old_count = Py_REFCNT(obj);
         for (int j = 0; j < 10000; j++) {
             Py_DECREF(obj);
         }
         Py_ssize_t current_count = Py_REFCNT(obj);
-        if (old_count != current_count) {
-            PyErr_SetString(PyExc_RuntimeError, "Reference count should not be changed.");
-            return NULL;
-        }
+        assert(old_count == current_count);
     }
     Py_RETURN_NONE;
 }
 
 static PyObject *
 test_immortal_none(PyObject *self, PyObject *Py_UNUSED(ignored))
 {
-    if (!_Py_IsImmortal(Py_None)) {
-        PyErr_Format(PyExc_RuntimeError, "%R should be the immportal object.", Py_None);
-        return NULL;
-    }
+    assert(_Py_IsImmortal(Py_None));
     Py_ssize_t old_count = Py_REFCNT(Py_None);
     for (int i = 0; i < 10000; i++) {
         Py_DECREF(Py_None);
     }
     Py_ssize_t current_count = Py_REFCNT(Py_None);
-    if (old_count != current_count) {
-        PyErr_SetString(PyExc_RuntimeError, "Reference count should not be changed.");
-        return NULL;
-    }
+    assert(old_count == current_count);
     Py_RETURN_NONE;
 }
 
 static PyObject *
 test_immortal_small_ints(PyObject *self, PyObject *Py_UNUSED(ignored))
 {
-    for(int i = -5; i <= 256; i++) {
+    for (int i = -5; i <= 256; i++) {
         PyObject *small_int = PyLong_FromLong(i);
-        if (!_Py_IsImmortal(small_int)) {
-            PyErr_Format(PyExc_RuntimeError, "Small int(%d) object should be the immportal object.", i);
-            return NULL;
-        }
+        assert(_Py_IsImmortal(small_int));
         Py_ssize_t old_count = Py_REFCNT(small_int);
         for (int j = 0; j < 10000; j++) {
             Py_DECREF(small_int);
         }
         Py_ssize_t current_count = Py_REFCNT(small_int);
-        if (old_count != current_count) {
-            PyErr_Format(PyExc_RuntimeError, "Reference count of %d should not be changed.", i);
-            return NULL;
-        }
+        assert(old_count == current_count);
     }
     Py_RETURN_NONE;
 }
 
 static PyObject *
 test_immortal_ellipsis(PyObject *self, PyObject *Py_UNUSED(ignored))
 {
-    if (!_Py_IsImmortal(Py_Ellipsis)) {
-        PyErr_SetString(PyExc_RuntimeError, "Ellipsis object should be the immportal object.");
-        return NULL;
-    }
+    assert(_Py_IsImmortal(Py_Ellipsis));
     Py_ssize_t old_count = Py_REFCNT(Py_Ellipsis);
     for (int i = 0; i < 10000; i++) {
         Py_DECREF(Py_Ellipsis);
     }
     Py_ssize_t current_count = Py_REFCNT(Py_Ellipsis);
-    if (old_count != current_count) {
-        PyErr_SetString(PyExc_RuntimeError, "Reference count should not be changed.");
-        return NULL;
-    }
+    assert(old_count == current_count);
     Py_RETURN_NONE;
 }