schema properties validation recursion fix

Author: p1c2u

openapi_spec_validator/validation/validators.py

@@ -65,6 +65,7 @@ def __init__(
         self.resolver_handlers = resolver_handlers
 
         self.operation_ids_registry: Optional[List[str]] = None
+        self.schema_ids_registry: Optional[List[str]] = None
         self.resolver = None
 
     def validate(
@@ -82,6 +83,7 @@ def iter_errors(
         self, instance: Mapping[Hashable, Any], spec_url: str = ""
     ) -> Iterator[ValidationError]:
         self.operation_ids_registry = []
+        self.schema_ids_registry = []
         self.resolver = self._get_resolver(spec_url, instance)
 
         yield from self.schema_validator.iter_errors(instance)
@@ -248,7 +250,12 @@ def _iter_schema_errors(
         if not hasattr(schema.content(), "__getitem__"):
             return
 
-        schema_type = schema.getkey("type")
+        assert self.schema_ids_registry is not None
+        schema_id = id(schema.content())
+        if schema_id in self.schema_ids_registry:
+            return
+        self.schema_ids_registry.append(schema_id)
+
         nested_properties = []
         if "allOf" in schema:
             all_of = schema / "allOf"

tests/integration/data/v3.0/property-recursive.yaml

@@ -0,0 +1,16 @@
+openapi: 3.0.0
+info:
+  version: '1.0.0'
+  title: 'Some Schema'
+paths: {}
+components:
+  schemas:    
+    SomeDataType:
+      type: object
+      properties:
+        id:
+          type: integer
+        prop1:
+          $ref: '#/components/schemas/SomeDataType'
+        prop2:
+          type: string

tests/integration/validation/test_validators.py

@@ -66,6 +66,7 @@ def local_test_suite_file_path(self, test_file):
             "petstore.yaml",
             "petstore-separate/spec/openapi.yaml",
             "parent-reference/openapi.yaml",
+            "property-recursive.yaml",
         ],
     )
     def test_valid(self, factory, validator_v30, spec_file):