freeze: make --all the default & deprecate it

Author: xavfernandez

news/4256.removal.rst

@@ -0,0 +1,2 @@
+Stop filtering the ``pip``, ``setuptools``, ``distribute`` and ``wheel`` packages from ``pip freeze``.
+The equivalent option ``--all`` is now deprecated and does nothing.

src/pip/_internal/commands/freeze.py

@@ -9,10 +9,9 @@
 from pip._internal.models.format_control import FormatControl
 from pip._internal.operations.freeze import freeze
 from pip._internal.utils.compat import stdlib_pkgs
+from pip._internal.utils.deprecation import deprecated
 from pip._internal.utils.typing import MYPY_CHECK_RUNNING
 
-DEV_PKGS = {'pip', 'setuptools', 'distribute', 'wheel'}
-
 if MYPY_CHECK_RUNNING:
     from optparse import Values
     from typing import List
@@ -64,10 +63,9 @@ def add_options(self):
         self.cmd_opts.add_option(cmdoptions.list_path())
         self.cmd_opts.add_option(
             '--all',
-            dest='freeze_all',
+            dest='freeze_all_used',
             action='store_true',
-            help='Do not skip these packages in the output:'
-                 ' {}'.format(', '.join(DEV_PKGS)))
+            help='Deprecated - Does nothing.')
         self.cmd_opts.add_option(
             '--exclude-editable',
             dest='exclude_editable',
@@ -80,9 +78,12 @@ def run(self, options, args):
         # type: (Values, List[str]) -> int
         format_control = FormatControl(set(), set())
         wheel_cache = WheelCache(options.cache_dir, format_control)
-        skip = set(stdlib_pkgs)
-        if not options.freeze_all:
-            skip.update(DEV_PKGS)
+        if options.freeze_all_used:
+            deprecated(
+                "--all is now the default behavior and does nothing",
+                None,
+                gone_in="23.3",
+            )
 
         cmdoptions.check_list_path_option(options)
 
@@ -94,7 +95,7 @@ def run(self, options, args):
             paths=options.path,
             isolated=options.isolated_mode,
             wheel_cache=wheel_cache,
-            skip=skip,
+            skip=set(stdlib_pkgs),
             exclude_editable=options.exclude_editable,
         )
 

tests/functional/test_freeze.py

@@ -76,10 +76,16 @@ def test_basic_freeze(script):
 
 def test_freeze_with_pip(script):
     """Test pip shows itself"""
-    result = script.pip('freeze', '--all')
+    result = script.pip('freeze')
     assert 'pip==' in result.stdout
 
 
+def test_freeze_all_deprecated(script):
+    """Test that using --all option produces a warning"""
+    result = script.pip('freeze', '--all', expect_stderr=True)
+    assert '--all is now the default behavior and does nothing' in result.stderr
+
+
 def test_freeze_with_invalid_names(script):
     """
     Test that invalid names produce warnings and are passed over gracefully.