Inconsistent parameter name in fit_sdm_cec_sam()?

[Peque]

The parameter beta_voc is named after v_oc.

The parameter alpha_sc is a bit inconsistent with this, since it should be alpha_isc (after i_sc).

In fact, the underlying SAM function also expects that name:

pvlib-python/pvlib/ivtools.py

Lines 95 to 99 in 93adb59

	datadict = {'tech_model': '6parsolve', 'financial_model': None,
	'celltype': celltype, 'Vmp': v_mp,
	'Imp': i_mp, 'Voc': v_oc, 'Isc': i_sc, 'alpha_isc': alpha_sc,
	'beta_voc': beta_voc, 'gamma_pmp': gamma_pmp,
	'Nser': cells_in_series, 'Tref': temp_ref}

[Peque]

I can push a MR if you want. Feel free to close this as well. I understand it is not too bad as-is and it breaks backwards compatibility. 😊

[cwhanse]

This is probably a legacy of PVLib Matlab, where alpha_isc has units of 1/C, and alpha_sc has units of A/C. Let's hold off a PR for now. I think we will rename a batch of arguments for v0.8, but I don't think we're agreed on the new names.

[Peque]

Just a note: having alpha in A/ºC and beta in V/ºC but gamma in %/ºC can cause trouble/confusion.

Also, in my probably biased and reduced experience, datasheets usually have these 3 values in %/ºC, maybe it could be interesting to consider a change to percentage as well.