You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that clearsky.ineichen is a disaster of a function. There's some unnecessary complexity inherited from PVLIB Matlab, and some additional complexity that I wrongly added.
In the spirit of simple functions, I think we should:
remove the time, latitude, location arguments in favor of apparent_zenith
make airmass a required argument
remove the ability for the function to calculate it's own solar position and airmass
remove the ability for the function to look up linke turbidity
The Location class's get_clearsky method, or similar, can provide the higher-level features.
My simplified solis PR #148 might provide some inspiration.
The text was updated successfully, but these errors were encountered:
I think that clearsky.ineichen is a disaster of a function. There's some unnecessary complexity inherited from PVLIB Matlab, and some additional complexity that I wrongly added.
In the spirit of simple functions, I think we should:
time, latitude, location
arguments in favor ofapparent_zenith
airmass
a required argumentThe
Location
class'sget_clearsky
method, or similar, can provide the higher-level features.My simplified solis PR #148 might provide some inspiration.
The text was updated successfully, but these errors were encountered: