Skip to content

simplify the clearsky.ineichen function #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue May 5, 2016 · 0 comments
Closed

simplify the clearsky.ineichen function #155

wholmgren opened this issue May 5, 2016 · 0 comments
Milestone

Comments

@wholmgren
Copy link
Member

I think that clearsky.ineichen is a disaster of a function. There's some unnecessary complexity inherited from PVLIB Matlab, and some additional complexity that I wrongly added.

In the spirit of simple functions, I think we should:

  • remove the time, latitude, location arguments in favor of apparent_zenith
  • make airmass a required argument
  • remove the ability for the function to calculate it's own solar position and airmass
  • remove the ability for the function to look up linke turbidity

The Location class's get_clearsky method, or similar, can provide the higher-level features.

My simplified solis PR #148 might provide some inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant