address original issue

Author: dplewis

3.0.0.md

@@ -59,11 +59,12 @@ Parse.Cloud.beforeSave('Post', function(request, response) {
 As we can see the current way, with backbone style callbacks is quite tough to read and maintain.
 It's also not really trivial to handle errors, as you need to pass the response.error to each error handlers.
 
-Now it can be modernized with promises:
+Do not return in beforeSave hooks as this may have prevent the hook from working.
 
 ```js
 // after (with promises)
 Parse.Cloud.beforeSave('MyClassName', (request) => {
+  // Don't return here use await / async
   return Parse.Cloud.httpRequest({
     url: request.object.get('fileURL')
   }).then((contents) => {

CHANGELOG.md

@@ -44,6 +44,7 @@ For more informations, visit the v3.0.0 [migration guide](https://github.com/par
 
 #### Breaking changes:
 * Cloud Code handlers have a new interface based on promises.
+* Returning in before hooks are deprecated.
 * response.success / response.error are removed in Cloud Code
 * Cloud Code runs with Parse-SDK 2.0
 * The aggregate now require aggregates to be passed in the form: `{"pipeline": [...]}`

spec/CloudCode.spec.js

@@ -193,31 +193,6 @@ describe('Cloud Code', () => {
     });
   });
 
-  it('test beforeSave applies changes and resolves returned promise', done => {
-    Parse.Cloud.beforeSave('Insurance', function(req) {
-      req.object.set('rate', '$49.99/Month');
-      return new Parse.Query('Pet').get(req.object.get('pet').id).then(pet => {
-        pet.set('healthy', true);
-        return pet.save();
-      });
-    });
-
-    const pet = new Parse.Object('Pet');
-    pet.set('healthy', false);
-    pet.save().then(pet => {
-      const insurance = new Parse.Object('Insurance');
-      insurance.set('pet', pet);
-      insurance.set('rate', '$5.00/Month');
-      insurance.save().then(insurance => {
-        expect(insurance.get('rate')).toEqual('$49.99/Month');
-        new Parse.Query('Pet').get(insurance.get('pet').id).then(pet => {
-          expect(pet.get('healthy')).toEqual(true);
-          done();
-        });
-      });
-    });
-  });
-
   it('test afterSave ran and created an object', function(done) {
     Parse.Cloud.afterSave('AfterSaveTest', function(req) {
       const obj = new Parse.Object('AfterSaveProof');

src/triggers.js

@@ -254,6 +254,7 @@ export function getResponseObject(request, resolve, reject) {
       // Use the JSON response
       if (
         response &&
+        typeof response === 'object' &&
         !request.object.equals(response) &&
         request.triggerName === Types.beforeSave
       ) {
@@ -573,16 +574,6 @@ export function maybeRunTrigger(
             auth
           );
         }
-
-        // beforeSave is expected to return null (nothing)
-        if (triggerType === Types.beforeSave) {
-          // if the beforeSave returned a promise, return null after the promise is resolved
-          if (promise && typeof promise.then === 'function') {
-            return promise.then(() => null);
-          }
-          return null;
-        }
-
         return promise;
       })
       .then(success, error);