Checking of new features in the latest dashboard version does not work

[damianstasik]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest versions of Parse Server and Parse Dashboard.

Issue Description

This condition will always be false, because package-json does not return custom properties by default.

Steps to reproduce

Set a breakpoint or try logging latestPackage.parseDashboardFeatures.

Actual Outcome

latestPackage.parseDashboardFeatures is undefined.

Expected Outcome

latestPackage.parseDashboardFeatures should be an array.

Environment

Node 14.17.3

Dashboard

• Parse Dashboard version: 3.2.1
• Browser (Safari, Chrome, Firefox, Edge, etc.): not relevant
• Browser version: not relevant

Server

• Parse Server version: not relevant
• Operating system: not relevant
• Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): not relevant

Database

• System (MongoDB or Postgres): not relevant
• Database version: not relevant
• Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): not relevant

Logs

[parse-github-assistant]

Thanks for opening this issue!

• 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

[mtrezza]

Is the "latest features" even used? The only purpose of this seems to display an upgrade prompt, but I have never seen such a prompt. I wonder whether this that made it into the open source codebase but is really non-functional?

parse-dashboard/src/dashboard/Apps/AppsIndex.react.js

Lines 140 to 147 in 3bc8eec

	let upgradePrompt = null;
	if (this.props.newFeaturesInLatestVersion.length > 0) {
	let newFeaturesNodes = this.props.newFeaturesInLatestVersion.map(feature => <strong>
	{feature}
	</strong>);
	upgradePrompt = <FlowFooter>
	Upgrade to the <a href='https://www.npmjs.com/package/parse-dashboard' target='_blank'>latest version</a> of Parse Dashboard to get access to: {joinWithFinal('', newFeaturesNodes, ', ', ' and ')}.
	</FlowFooter>

We could possibly even remove the whole feature if it's not applicable to the open source version.

[damianstasik]

That could be due to the fact that newFeaturesInLatestVersion was always empty, even if there were new features in the latest version. If we would remove this thing completely it could be a non-breaking release due to this bug.

[mtrezza]

If this bug fix enables a "forgotten" feature, we should probably check how this feature behaves before merging. It could be too intrusive, break something else that is incompatible, or display incorrect information.

[damianstasik]

@mtrezza I removed the "Data Browser" entry from package.json and started the dashboard to look for the message and it shows at the bottom of the page if you enter apps index. It correctly listed the "new feature" and the link to the package on npmjs.com is correct.

[mtrezza]

That's a pretty neat feature! So we can add a feature entry to package.json and all dashboard deployments will see that info?

[damianstasik]

Yes! The only problem is that dashboards without the #1894 would not see anything 😞

[mtrezza]

Well let's merge it then!

[mtrezza]

Closing via #1894.