Allow macOS app keychain to upgrade

Author: cbaker6

CHANGELOG.md

@@ -8,7 +8,7 @@
 [Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.9.7...1.9.8)
 
 __Fixes__
-- Use a seperate Keychain for each app bundleId. This only effects macOS apps as their Keychain is handled by the OS differently. macOS app users will need to sign-in again after upgrading to this version. ([#224](https://github.com/parse-community/Parse-Swift/pull/224)), thanks to [Corey Baker](https://github.com/cbaker6).
+- Use a seperate Keychain for each app bundleId. This only effects macOS apps as their Keychain is handled by the OS differently. For macOS app developers only, the user who logged in last to your app will have their Keychain upgraded to the patched version. Other users/apps will either need to login again or logout then login again ([#224](https://github.com/parse-community/Parse-Swift/pull/224)), thanks to [Corey Baker](https://github.com/cbaker6).
 
 ### 1.9.7
 [Full Changelog](https://github.com/parse-community/Parse-Swift/compare/1.9.6...1.9.7)

Sources/ParseSwift/Parse.swift

@@ -141,17 +141,15 @@ public struct ParseSwift {
             let oneNineEightSDKVersion = try ParseVersion("1.9.8")
 
             // All migrations from previous versions to current should occur here:
+            #if !os(Linux) && !os(Android)
             if previousSDKVersion < oneNineEightSDKVersion {
                 // Old macOS Keychain can't be used because it's global to all apps.
-                #if !os(macOS) && !os(Linux) && !os(Android)
                 _ = KeychainStore.old
                 KeychainStore.shared.copy(keychain: KeychainStore.old)
-                #endif
-                #if !os(Linux) && !os(Android)
                 // Need to delete the old Keychain because a new one is created with bundleId.
                 try? KeychainStore.old.deleteAll()
-                #endif
             }
+            #endif
             if currentSDKVersion > previousSDKVersion {
                 ParseVersion.current = currentSDKVersion.string
             }

Tests/ParseSwiftTests/InitializeSDKTests.swift

@@ -293,21 +293,12 @@ class InitializeSDKTests: XCTestCase {
                                   masterKey: "masterKey",
                                   serverURL: url)
             XCTAssertEqual(ParseVersion.current, ParseConstants.version)
-            #if !os(macOS)
             XCTAssertEqual(BaseParseUser.current, user)
             XCTAssertEqual(Installation.current, installation)
             XCTAssertEqual(Config.current?.welcomeMessage, config.welcomeMessage)
             XCTAssertEqual(Config.current?.winningNumber, config.winningNumber)
             let defaultACL = try? ParseACL.defaultACL()
             XCTAssertEqual(defaultACL, acl)
-            #else
-            XCTAssertNil(BaseParseUser.current)
-            XCTAssertNil(Installation.current)
-            XCTAssertNil(Config.current?.welcomeMessage)
-            XCTAssertNil(Config.current?.winningNumber)
-            let defaultACL = try? ParseACL.defaultACL()
-            XCTAssertNil(defaultACL)
-            #endif
             expectation1.fulfill()
         }
         wait(for: [expectation1], timeout: 10.0)