Skip to content

Probably unused file PFBlockRetryer #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbsgn opened this issue Aug 14, 2015 · 3 comments
Closed

Probably unused file PFBlockRetryer #15

rbsgn opened this issue Aug 14, 2015 · 3 comments
Labels
type:feature New feature or improvement of existing feature
Milestone

Comments

@rbsgn
Copy link

rbsgn commented Aug 14, 2015

I've been investigating how Parse for iOS does retrying upon -saveEventually and found PFBlockRetryer class which is not included anywhere but tests. Is this file no longer used? Can I rely on this class in the future or it will be deleted?

@nlutsenko
Copy link
Contributor

Hey @nskboy , good find. It in indeed unused and we should remove it to keep the ask free of dead code.

@nlutsenko nlutsenko self-assigned this Aug 14, 2015
@nlutsenko nlutsenko added this to the 1.8.1 milestone Aug 14, 2015
@nlutsenko
Copy link
Contributor

The logic for retrying on saveEventually calls actually lives in PFEventuallyQueue

Another piece of retrying logic that we have lives in PFURLSessionCommandRunner, but that is used rather for saveInBackground or any other network request.

@rbsgn
Copy link
Author

rbsgn commented Aug 15, 2015

Thanks for providing more details about retrying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants