Skip to content

I seem to still get PFCommandCache memory errors #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tealshift opened this issue Aug 14, 2017 · 24 comments
Closed

I seem to still get PFCommandCache memory errors #1168

tealshift opened this issue Aug 14, 2017 · 24 comments
Assignees

Comments

@tealshift
Copy link
Contributor

I've made a stackoverflow post here: https://stackoverflow.com/q/45683981/1921002

Let me know if there is any more information you need to help resolve.

@flovilmart flovilmart self-assigned this Aug 15, 2017
@flovilmart
Copy link
Contributor

We see this as well, we're working on a fix at the comment and expect to release soon.

@flovilmart
Copy link
Contributor

@tealshift any STR that would help me reproduce and make sure the fix is 👍

@flovilmart
Copy link
Contributor

@tealshift can you try with the branch: fix/1168-heapcorruption

example with Podfile:

pod 'Parse', :git => 'https://github.com/parse-community/Parse-SDK-iOS-OSX.git', :branch => 'fix/1168-heapcorruption'

@tealshift
Copy link
Contributor Author

@flovilmart Alright, I'll give it a shot. I'm not the best memory debugger but I'll try my best. Can you tell me what an STR is?

@flovilmart
Copy link
Contributor

STR: Step To Reproduce, that would be helpful to ensure that this is gone for good, we have the issue as well in production, but never noticed it in our dev or QA builds.

@tealshift
Copy link
Contributor Author

tealshift commented Aug 16, 2017

I'm still setting up my project with the new SDK, but did you try profiling Zombies using Release "build configuration" in the scheme? That's what I've done to reproduce and sounds like the ticket.

@flovilmart
Copy link
Contributor

yep, seems fixed, can you try again with the same steps with the branch and let me know if that's fixed?

@tealshift
Copy link
Contributor Author

Hmmm I just ran into this with the new SDK.
screen shot 2017-08-16 at 9 39 47 am

@tealshift
Copy link
Contributor Author

tealshift commented Aug 16, 2017

Sorry but I'm having trouble converting my framework import from manual to CocoaPods. I'm not 100% certain I had the new framework from pods linked. (update: Yes I did have the new framework here.)

@flovilmart
Copy link
Contributor

You were importing it manually? That’s trickier. Would you be able to make a sample app that has the issue?

@flovilmart
Copy link
Contributor

flovilmart commented Aug 16, 2017 via email

@tealshift
Copy link
Contributor Author

tealshift commented Aug 16, 2017

screen shot 2017-08-16 at 10 23 01 am

To clarify, by "manual" I mean I simply dragged the framework file into my project. I'm not terribly familiar with the terminology.
My issue is with my iMessage target's bridging header trying to import an objc header that imports <Parse/Parse.h> resulting in "File not found" build error. I don't know why this wasn't an issue without pods.

@tealshift
Copy link
Contributor Author

Ok, I just fixed my pod issues and I've definitely removed the old framework file. The Zombie Messaged event still occurs as I screenshotted so I must have had the new stuff linked. Anything else you'd like to see?

@flovilmart
Copy link
Contributor

Do you have a code example that triggers this behavior / sample project?

@tealshift
Copy link
Contributor Author

I made a new project but didn't get the zombie message. It could take me a long time to find the actual cause in my project, sadly. :(

@tealshift
Copy link
Contributor Author

I can't share my project, but I'd gladly take some pointers on finding the cause.

@flovilmart
Copy link
Contributor

Yeah, I understand that, i’ll Investigate further.

@flovilmart
Copy link
Contributor

I'm seeing something as well, with the zombie tools on that branch, investigating now.

@flovilmart
Copy link
Contributor

@tealshift just updated the branch, can you tell me if that's better for you now? I don't see it anymore, an no leaks either are popping.

@tealshift
Copy link
Contributor Author

Looks good! My profiler found a zombie before the pod update and didn't right after. Thank you!

@flovilmart
Copy link
Contributor

YES! Very nice! And AFAICT, it seems that the deallocation is happening correctly as well :)

@flovilmart
Copy link
Contributor

@tealshift do you confirm you don't have any zombie messaging nor leaks around the command cache anymore? Do you mind having a look at the PR and let me know what you think?

@tealshift
Copy link
Contributor Author

Yeah, no issues from Parse so far! I read your recent commits and though I haven't played much with block execution myself, they look correct.

@flovilmart
Copy link
Contributor

Good to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants