Skip to content

8320310: CompiledMethod::has_monitors flag can be incorrect #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

satyenme
Copy link

@satyenme satyenme commented May 2, 2025

Backporting JDK-8320310: CompiledMethod::has_monitors flag can be incorrect. The proposed fix is to rely on Method::has_monitor_bytecodes to set the has_monitors flag when compiling, which is immune to issues where not all byte codes of a method are parsed during compilation. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is almost clean (missing src/hotspot/share/runtime/continuationFreezeThaw.cpp).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320310 needs maintainer approval

Issue

  • JDK-8320310: CompiledMethod::has_monitors flag can be incorrect (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1732/head:pull/1732
$ git checkout pull/1732

Update a local copy of the PR:
$ git checkout pull/1732
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1732

View PR using the GUI difftool:
$ git pr show -t 1732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1732.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c8fa3e21e6a4fd7846932b545a1748cc1dc6d9f1 8320310: CompiledMethod::has_monitors flag can be incorrect May 2, 2025
@openjdk
Copy link

openjdk bot commented May 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 2, 2025
@mlbridge
Copy link

mlbridge bot commented May 2, 2025

Webrevs

@satyenme satyenme closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant