8320310: CompiledMethod::has_monitors flag can be incorrect #1732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8320310: CompiledMethod::has_monitors flag can be incorrect. The proposed fix is to rely on Method::has_monitor_bytecodes to set the has_monitors flag when compiling, which is immune to issues where not all byte codes of a method are parsed during compilation. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is almost clean (missing
src/hotspot/share/runtime/continuationFreezeThaw.cpp
).Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1732/head:pull/1732
$ git checkout pull/1732
Update a local copy of the PR:
$ git checkout pull/1732
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1732/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1732
View PR using the GUI difftool:
$ git pr show -t 1732
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1732.diff
Using Webrev
Link to Webrev Comment