Is this intended?

[yuwenyong]

I'm reading source code recently.In function "utf8ToCodepoint" contains code below(almost line 202 in json_writer.cpp):
if (calculated >= 0xD800 && calculated >= 0xDFFF) return REPLACEMENT_CHARACTER;
It seems first condition is redundant. Should second condition be less equal? Is this intended?

[cdunn2001]

https://github.com/open-source-parsers/jsoncpp/blob/master/src/lib_json/json_writer.cpp#L173

Maybe you are looking at old code?

[yuwenyong]

I am looking at the code follow your link and it's the same version as mine.The "problem code" is in the 201 line.

[cdunn2001]

@yuwenyong, thanks for following up. There seems to be a bug in #687. I'll give the author some time to respond, but if you'd like, go ahead and submit a pull-request with your proposed fix.

[wenlian]

it may cause some chinese punctuation transcoding get wrong code, such as: , (0xFF0C) ? (0xFF1F) ! (0xFF01) ; (0xFF1B) ...

[pkierski]

Sorry for late response. It's a bug, #712 resolves it.

[cdunn2001]

Fixed by #712/#714.