Skip to content

Commit 95eb83f

Browse files
committed
btl/sm: use the shared-memory single-copy framework for single-copy
This commit removes the dedicated shared-memory single-copy support from btl/sm. This support is now provided by the shared-memory single-copy (smsc) framework. The btl_sm_single_copy_mechanism MCA variable has been removed. Use either the component priority parameters (ex. scsm_xpmem_priority) or component selection (--mca smsc) to select the single-copy mechanism. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
1 parent 53891b6 commit 95eb83f

12 files changed

+170
-1294
lines changed

opal/mca/btl/sm/Makefile.am

+1-5
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# Copyright (c) 2011-2014 Los Alamos National Security, LLC. All rights
1414
# reserved.
1515
# Copyright (c) 2017 IBM Corporation. All rights reserved.
16-
# Copyright (c) 2020 Google, LLC. All rights reserved.
16+
# Copyright (c) 2020-2021 Google, LLC. All rights reserved.
1717
# $COPYRIGHT$
1818
#
1919
# Additional copyrights may follow
@@ -38,10 +38,6 @@ libmca_btl_sm_la_sources = \
3838
btl_sm_fbox.h \
3939
btl_sm_get.c \
4040
btl_sm_put.c \
41-
btl_sm_xpmem.c \
42-
btl_sm_xpmem.h \
43-
btl_sm_knem.c \
44-
btl_sm_knem.h \
4541
btl_sm_types.h \
4642
btl_sm_virtual.h
4743

opal/mca/btl/sm/btl_sm.h

+12-57
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@
6161

6262
#include "opal/mca/pmix/pmix-internal.h"
6363

64-
#include "btl_sm_knem.h"
65-
#include "btl_sm_xpmem.h"
66-
6764
BEGIN_C_DECLS
6865

6966
#define min(a, b) ((a) < (b) ? (a) : (b))
@@ -121,32 +118,12 @@ int mca_btl_sm_sendi(struct mca_btl_base_module_t *btl, struct mca_btl_base_endp
121118
* @param endpoint (IN) BTL addressing information
122119
* @param descriptor (IN) Description of the data to be transferred
123120
*/
124-
#if OPAL_BTL_SM_HAVE_XPMEM
125-
int mca_btl_sm_put_xpmem(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
126-
void *local_address, uint64_t remote_address,
127-
mca_btl_base_registration_handle_t *local_handle,
128-
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
129-
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
130-
void *cbdata);
131-
#endif
132-
133-
#if OPAL_BTL_SM_HAVE_CMA
134-
int mca_btl_sm_put_cma(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
135-
void *local_address, uint64_t remote_address,
136-
mca_btl_base_registration_handle_t *local_handle,
137-
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
138-
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
139-
void *cbdata);
140-
#endif
141-
142-
#if OPAL_BTL_SM_HAVE_KNEM
143-
int mca_btl_sm_put_knem(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
144-
void *local_address, uint64_t remote_address,
145-
mca_btl_base_registration_handle_t *local_handle,
146-
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
147-
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
148-
void *cbdata);
149-
#endif
121+
int mca_btl_sm_put(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
122+
void *local_address, uint64_t remote_address,
123+
mca_btl_base_registration_handle_t *local_handle,
124+
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
125+
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
126+
void *cbdata);
150127

151128
/**
152129
* Initiate an synchronous get.
@@ -155,34 +132,12 @@ int mca_btl_sm_put_knem(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *end
155132
* @param endpoint (IN) BTL addressing information
156133
* @param descriptor (IN) Description of the data to be transferred
157134
*/
158-
#if OPAL_BTL_SM_HAVE_XPMEM
159-
int mca_btl_sm_get_xpmem(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
160-
void *local_address, uint64_t remote_address,
161-
mca_btl_base_registration_handle_t *local_handle,
162-
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
163-
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
164-
void *cbdata);
165-
#endif
166-
167-
#if OPAL_BTL_SM_HAVE_CMA
168-
int mca_btl_sm_get_cma(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
169-
void *local_address, uint64_t remote_address,
170-
mca_btl_base_registration_handle_t *local_handle,
171-
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
172-
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
173-
void *cbdata);
174-
#endif
175-
176-
#if OPAL_BTL_SM_HAVE_KNEM
177-
int mca_btl_sm_get_knem(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
178-
void *local_address, uint64_t remote_address,
179-
mca_btl_base_registration_handle_t *local_handle,
180-
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
181-
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
182-
void *cbdata);
183-
#endif
184-
185-
ino_t mca_btl_sm_get_user_ns_id(void);
135+
int mca_btl_sm_get(mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoint,
136+
void *local_address, uint64_t remote_address,
137+
mca_btl_base_registration_handle_t *local_handle,
138+
mca_btl_base_registration_handle_t *remote_handle, size_t size, int flags,
139+
int order, mca_btl_base_rdma_completion_fn_t cbfunc, void *cbcontext,
140+
void *cbdata);
186141

187142
/**
188143
* Allocate a segment.

0 commit comments

Comments
 (0)