Skip to content

NC | Update config might result with deleted config file #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romayalon opened this issue Apr 2, 2025 · 0 comments
Open

NC | Update config might result with deleted config file #8930

romayalon opened this issue Apr 2, 2025 · 0 comments
Labels

Comments

@romayalon
Copy link
Contributor

Environment info

  • NooBaa Version: 4.19
  • Platform: NC

Actual behavior

  1. While debugging notifications + lifecycle, in an old version of NC lifecycle we used update_config_file() and we saw that on some failure the buckets config files were deleted, therefore we checked the code and saw that
    it might be because of the next line -
await safe_unlink(fs_context, config_path, stat, undefined, tmp_dir_path); 

we need to evaluate this code more and fix this potential issue.

Expected behavior

  1. config files can not be deleted as a result of a failure of update_config_file()

Steps to reproduce

  1. it's probably can be reproducible artificially when throwing an error after the safe_unlink()

More information - Screenshots / Logs / Other output

@romayalon romayalon added the NS-FS label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant