NC | NSFS | Improve Event on Get Object Operation Failure

[shirady]

Environment info

• NooBaa Version: master, 5.19.0
• Platform: NC

Actual behavior

1. Currently When a Get Object operation fails on NoSuckKey the event noobaa_object_get_failed does not log.

Expected behavior

1. When a Get Object operation fails on NoSuckKey the event noobaa_object_get_failed will be logged.

Steps to reproduce

I saw it on the customer case (using 5.17.0), so the steps might not be accurate.

1. Create NC account and bucket.
2. Start the NSFS server and check the connection.
3. Try to get a non-existing object (should fail on NoSuckKey).
4. Search in the logs for noobaa_object_get_failed event.

More information - Screenshots / Logs / Other output

I assume that that I didn't see this event as the get_object has two calls to the object_sdk - read_object_md and read_object_stream, and we currently create the noobaa_object_get_failed only on the read_object_stream (while the failure starts in read_object_md).

[naveenpaul1]

@shirady Do we really need to log this event? This is not an issue or an event from Noobaa side, And if we add this event there is a chance the event log can be filled with this event. WDYT?

[shirady]

@naveenpaul1 I raised it as an issue because while I was analyzing logs and I saw it.
Maybe you have a good point about filling the events - so maybe the solution is to improve our event doc so we will know what to expect, and also look at the other events and see that they are not filling the logs too much.
Anyway, I don't have a solution now, but when the issue is picked, we can have an internal team discussion.

[github-actions]

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.