Skip to content

adding SliceEncodingDirection to afni.TShift #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fliem opened this issue Oct 25, 2018 · 1 comment
Closed

adding SliceEncodingDirection to afni.TShift #2752

fliem opened this issue Oct 25, 2018 · 1 comment
Milestone

Comments

@fliem
Copy link
Contributor

fliem commented Oct 25, 2018

Summary

BIDS allows to specify SliceEncodingDirection. How about adding a parameter to afni.TShift to use this information and SliceTiming from BIDS sidecar files directly.

This comes via fmriprep. @effigies suggested to add this here.

BIDS allows to declare SliceEncodingDirection to specify the direction of SliceTiming. What do you think about adding a SliceEncodingDirection input ({k, k-}) to afni.TShift. If this is k-, reverse the slice timing list before running the correction.

Does it make sense to also add i, j, i-, j-? Or does it make sense to always assume that slices have been acquired along the third axis?

What do you think?

@fliem fliem changed the title adding SliceEncodingDirection to afni.TShift adding SliceEncodingDirection to afni.TShift Oct 25, 2018
@effigies
Copy link
Member

I'll review, so I'd say full speed ahead. :-)

SliceTiming is passed to the slice_timing input, defined here:

slice_timing = traits.Either(
File(exists=True),
traits.List(traits.Float),
desc='time offsets from the volume acquisition onset for each slice',
argstr='-tpattern @%s',
xor=['tpattern'])

I would start with {k, k-} as you suggest, as that will cover the majority of the cases, and we can think about i and j in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants