Skip to content

updating metadata #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2021
Merged

updating metadata #12

merged 2 commits into from
Feb 24, 2021

Conversation

ingride
Copy link
Contributor

@ingride ingride commented Feb 24, 2021

@ingride ingride added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 24, 2021
erezrokah
erezrokah approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good per the failing tests

@ingride ingride marked this pull request as ready for review February 24, 2021 11:36
@ingride ingride merged commit f92c4f9 into main Feb 24, 2021
@erezrokah erezrokah mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingride @erezrokah