time: fix strftime not raising for invalid year values

lazka · lazka · commit e178448c0638 · 2023-08-25T11:30:13.000+02:00
It's crt specific and not compiler specific.
This fixes a test case in test_time
diff --git a/Modules/timemodule.c b/Modules/timemodule.c
@@ -783,7 +783,7 @@ time_strftime(PyObject *module, PyObject *args)
         return NULL;
     }
 
-#if defined(_MSC_VER) || (defined(__sun) && defined(__SVR4)) || defined(_AIX) || defined(__VXWORKS__)
+#if defined(MS_WINDOWS) || (defined(__sun) && defined(__SVR4)) || defined(_AIX) || defined(__VXWORKS__)
     if (buf.tm_year + 1900 < 1 || 9999 < buf.tm_year + 1900) {
         PyErr_SetString(PyExc_ValueError,
                         "strftime() requires year in [1; 9999]");

Original file line number	Diff line number	Diff line change
`@@ -783,7 +783,7 @@ time_strftime(PyObject module, PyObject args)`
`783`	`783`	`return NULL;`
`784`	`784`	`}`
`785`	`785`
`786`		`-#if defined(_MSC_VER) \|\| (defined(__sun) && defined(__SVR4)) \|\| defined(_AIX) \|\| defined(__VXWORKS__)`
	`786`	`+#if defined(MS_WINDOWS) \|\| (defined(__sun) && defined(__SVR4)) \|\| defined(_AIX) \|\| defined(__VXWORKS__)`
`787`	`787`	`if (buf.tm_year + 1900 < 1 \|\| 9999 < buf.tm_year + 1900) {`
`788`	`788`	`PyErr_SetString(PyExc_ValueError,`
`789`	`789`	`"strftime() requires year in [1; 9999]");`