Skip to content

makeParamHelpList() broken due to R help page update #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pat-s opened this issue Jul 18, 2022 · 1 comment · Fixed by #2845
Closed

makeParamHelpList() broken due to R help page update #2843

pat-s opened this issue Jul 18, 2022 · 1 comment · Fixed by #2845
Labels
type-bug

Comments

@pat-s
Copy link
Member

pat-s commented Jul 18, 2022

@mb706 Pinging you, since you implemented this one in 2017.

Specifically, makeParamHelpList does not work anymore as the returned list in tab is empty (see link) - I suspect the HTML structure in the R help pages got updated (I don't see the element //table[@summary='R argblock'] anymore in the html output of a help page).
See also https://github.com/mlr-org/mlr/runs/7383000156?check_suite_focus=true#step:21:456.

I've digged in a bit but never fiddled around with {XML} so far and it would take me probably too much time to fix this for a quite low return.

Do you want to fix this? If not, I'd remove the logic and related tests.
@pat-s pat-s added the type-bug label Jul 18, 2022
@mb706
Copy link
Contributor

mb706 commented Jul 25, 2022

Back from my vacation, I will look into this

@mb706 mb706 mentioned this issue Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix makeParamHelpList for R-devel mlr-org/mlr
2 participants
@pat-s @mb706