Skip to content

ImplicitMSALAuthenticationProvider is not exported in index.js #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darrelmiller opened this issue Sep 22, 2019 · 3 comments · Fixed by #348
Closed

ImplicitMSALAuthenticationProvider is not exported in index.js #230

darrelmiller opened this issue Sep 22, 2019 · 3 comments · Fixed by #348

Comments

@darrelmiller
Copy link
Contributor

darrelmiller commented Sep 22, 2019

We should add this file to the list of files we export.

Currently you need to export the file explicitly like this:

import { ImplicitMSALAuthenticationProvider }  from "@microsoft/microsoft-graph-client/lib/src/ImplicitMSALAuthenticationProvider";

Ideally we should be able to do

import * as MicrosoftGraph from "@microsoft/microsoft-graph-client";
@ghost ghost added the ToTriage label Sep 22, 2019
@darrelmiller darrelmiller changed the title Currently we do not export ImplicitMSALAuthenticationProvider in index.js ImplicitMSALAuthenticationProvider is not exported in index.js Sep 22, 2019
@krototype krototype self-assigned this Sep 25, 2019
@ghost ghost removed the ToTriage label Sep 25, 2019
@darrelmiller
Copy link
Contributor Author

/cc @muthurathinam Was this intentionally not exported?

@pl4nty
Copy link

pl4nty commented Oct 21, 2019

Worth noting MSALAuthenticationProviderOptions isn't exported either, even though the Authentication section of the readme uses new MicrosoftGraph.MSALAuthenticationProviderOptions(graphScopes);

@sowvikr
Copy link

sowvikr commented Dec 30, 2019

How the code is not reviewed and merged into the master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants