Skip to content

Bump Folly to v2024.10.14.00 #14453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jonthysell opened this issue Mar 26, 2025 · 3 comments · May be fixed by #14532
Open

Bump Folly to v2024.10.14.00 #14453

jonthysell opened this issue Mar 26, 2025 · 3 comments · May be fixed by #14532
Assignees
@TatianaKapos
Labels
Area: Build Infrastructure enhancement Integration Follow-up Workstream: Releases and Integrations Keep RNW current with RN releases.
Milestone
0.79

Comments

@jonthysell
Copy link
Contributor

Summary

Upstream, React Native has been using Folly v2024.10.14.00 since October 2024: facebook/react-native@37375d8

We should update to that version.

Motivation

There may be subtle problems and/or behaviour differences if our Folly version is too out of date.

Basic Example

No response

Open Questions

There have been some large changes in Folly by this release, including moving some files (that we fork) into a new json folder. There's also a new dependency on the fast_float library that we'll need to reconcile integrating into our code: https://github.com/fastfloat/fast_float
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 26, 2025
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 27, 2025
@chrisglein chrisglein added this to the Next milestone Mar 27, 2025
@chrisglein
Copy link
Member

Another candidate for the integrate script to look at.

@jonthysell
Copy link
Contributor Author

Another candidate for the integrate script to look at.

This would require more work as the dependency is not defined in any package.json - so the script would have to learn where to look upstream (I think it's in a ios build file?) and then try to bump the version, then update overrides. So a bunch of new work.

@jonthysell
Copy link
Contributor Author

I suspect that updating Folly will help with a variety of issues, esp. with the debugger as the code paths are hit when parsing JSON when connecting to the Metro inspector.

While it's a nontrivial amount of work (updating to the new file hierarchy and consuming fast_float) I think it might be worth considering for 0.79 (or 0.80 at least).

It might resolve some of the issues we're having with debugging (or at least rule out Folly being a culprit).

@chrisglein chrisglein modified the milestones: Next, 0.79 Apr 10, 2025
@TatianaKapos TatianaKapos linked a pull request Apr 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Area: Build Infrastructure enhancement Integration Follow-up Workstream: Releases and Integrations Keep RNW current with RN releases.
Projects
None yet
Milestone
0.79
Development

Successfully merging a pull request may close this issue.

Bump folly to 2024.10.14.00 TatianaKapos/react-native-windows
3 participants
@jonthysell @chrisglein @TatianaKapos