Skip to content

Add default case to facebook::react::displayModeToInt() #14281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Yajur-Grover opened this issue Jan 15, 2025 · 1 comment · Fixed by #14310
Closed

Add default case to facebook::react::displayModeToInt() #14281

Yajur-Grover opened this issue Jan 15, 2025 · 1 comment · Fixed by #14310
Assignees
@Yajur-Grover
Labels
enhancement Integration Follow-up Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Next

Comments

@Yajur-Grover
Copy link
Contributor

Yajur-Grover commented Jan 15, 2025 •
edited
Loading

Problem Description

In the displayModeToInt() function, there is not default case defined which is causing the following warning:

##[error]node_modules\react-native\ReactCommon\react\renderer\uimanager\primitives.h(163,1): Error C2220: the following warning is treated as an error
D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\uimanager\primitives.h(163,1): error C2220: the following warning is treated as an error [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]
##[warning]node_modules\react-native\ReactCommon\react\renderer\uimanager\primitives.h(163,1): Warning C4715: 'facebook::react::displayModeToInt': not all control paths return a value
D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\uimanager\primitives.h(163,1): warning C4715: 'facebook::react::displayModeToInt': not all control paths return a value [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]

Adding the default case removes the warning and resolves the issue.

Link to the integration where the error originated

#14278

Link to commit

facebook/react-native@dbb75e3

There was no change to the function in primitives.h directly in this integration period, but this was the only commit that references the function in the commit range.

Forked files

packages/react-native/ReactCommon/react/renderer/uimanager/primitives.h

Upstream PR

facebook/react-native#48711

Build Configuration

None
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 15, 2025
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jan 27, 2025
@chrisglein
Copy link
Member

@Yajur-Grover is planning on addressing this with the next integration PR.

@chrisglein chrisglein added this to the Next milestone Jan 27, 2025
@Yajur-Grover Yajur-Grover mentioned this issue Jan 27, 2025
Merged
@chrisglein chrisglein added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Feb 27, 2025
@anupriya13 anupriya13 mentioned this issue May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yajur-Grover Yajur-Grover

Labels
enhancement Integration Follow-up Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Integrate RN Nightly Build 0.79.0-nightly-20250123-d1028885e Yajur-Grover/react-native-windows
2 participants
@chrisglein @Yajur-Grover