Skip to content

Commit 621f47a

Browse files
BillyONealBillyONeal
authored
Avoid tripping over 32 bit time_t mistakes. (#1094)
Resolves #1090
1 parent 74d3e8d commit 621f47a

File tree

2 files changed

+84
-86
lines changed

2 files changed

+84
-86
lines changed

‎Release/src/utilities/asyncrt_utils.cpp

+14-16
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ std::string __cdecl conversions::to_utf8string(const utf16string& value) { retur
618618

619619
utf16string __cdecl conversions::to_utf16string(const std::string& value) { return utf8_to_utf16(value); }
620620

621-
static const uint64_t ntToUnixOffsetSeconds = 11644473600U; // diff between windows and unix epochs (seconds)
621+
static const int64_t ntToUnixOffsetSeconds = 11644473600; // diff between windows and unix epochs (seconds)
622622

623623
datetime __cdecl datetime::utc_now()
624624
{
@@ -634,10 +634,10 @@ datetime __cdecl datetime::utc_now()
634634
#else // LINUX
635635
struct timeval time;
636636
gettimeofday(&time, nullptr);
637-
uint64_t result = ntToUnixOffsetSeconds + time.tv_sec;
637+
int64_t result = ntToUnixOffsetSeconds + time.tv_sec;
638638
result *= _secondTicks; // convert to 10e-7
639639
result += time.tv_usec * 10; // convert and add microseconds, 10e-6 to 10e-7
640-
return datetime(result);
640+
return datetime(static_cast<interval_type>(result));
641641
#endif
642642
}
643643

@@ -646,7 +646,7 @@ static const char monthNames[] = "Jan\0Feb\0Mar\0Apr\0May\0Jun\0Jul\0Aug\0Sep\0O
646646

647647
utility::string_t datetime::to_string(date_format format) const
648648
{
649-
const uint64_t input = m_interval / _secondTicks; // convert to seconds
649+
const int64_t input = static_cast<int64_t>(m_interval / _secondTicks); // convert to seconds
650650
const int frac_sec = static_cast<int>(m_interval % _secondTicks);
651651
const time_t time = static_cast<time_t>(input - ntToUnixOffsetSeconds);
652652
struct tm t;
@@ -797,22 +797,20 @@ static int atoi2(const CharT* str)
797797
return (static_cast<unsigned char>(str[0]) - '0') * 10 + (static_cast<unsigned char>(str[1]) - '0');
798798
}
799799

800-
static const time_t maxTimeT = sizeof(time_t) == 4 ? (time_t)INT_MAX : (time_t)LLONG_MAX;
801-
802-
static time_t timezone_adjust(time_t result, unsigned char chSign, int adjustHours, int adjustMinutes)
800+
static int64_t timezone_adjust(int64_t result, unsigned char chSign, int adjustHours, int adjustMinutes)
803801
{
804802
if (adjustHours > 23)
805803
{
806-
return (time_t)-1;
804+
return -1;
807805
}
808806

809807
// adjustMinutes > 59 is impossible due to digit 5 check
810808
const int tzAdjust = adjustMinutes * 60 + adjustHours * 60 * 60;
811809
if (chSign == '-')
812810
{
813-
if (maxTimeT - result < tzAdjust)
811+
if (INT64_MAX - result < tzAdjust)
814812
{
815-
return (time_t)-1;
813+
return -1;
816814
}
817815

818816
result += tzAdjust;
@@ -821,7 +819,7 @@ static time_t timezone_adjust(time_t result, unsigned char chSign, int adjustHou
821819
{
822820
if (tzAdjust > result)
823821
{
824-
return (time_t)-1;
822+
return -1;
825823
}
826824

827825
result -= tzAdjust;
@@ -830,10 +828,10 @@ static time_t timezone_adjust(time_t result, unsigned char chSign, int adjustHou
830828
return result;
831829
}
832830

833-
static time_t make_gm_time(struct tm* t)
831+
static int64_t make_gm_time(struct tm* t)
834832
{
835833
#ifdef _MSC_VER
836-
return _mkgmtime(t);
834+
return static_cast<int64_t>(_mkgmtime(t));
837835
#elif (defined(ANDROID) || defined(__ANDROID__))
838836
// HACK: The (nonportable?) POSIX function timegm is not available in
839837
// bionic. As a workaround[1][2], we set the C library timezone to
@@ -867,9 +865,9 @@ static time_t make_gm_time(struct tm* t)
867865
unsetenv("TZ");
868866
}
869867
}
870-
return time;
868+
return static_cast<int64_t>(time);
871869
#else // ^^^ ANDROID // Other POSIX platforms vvv
872-
return timegm(t);
870+
return static_cast<int64_t>(timegm(t));
873871
#endif // _MSC_VER
874872
}
875873

@@ -916,7 +914,7 @@ zone = "UT" / "GMT" ; Universal Time
916914
datetime __cdecl datetime::from_string(const utility::string_t& dateString, date_format format)
917915
{
918916
datetime result;
919-
time_t seconds;
917+
int64_t seconds;
920918
uint64_t frac_sec = 0;
921919
struct tm t{};
922920
auto str = dateString.c_str();

‎Release/tests/functional/utils/datetime.cpp

+70-70
Original file line numberDiff line numberDiff line change
@@ -133,75 +133,77 @@ SUITE(datetime)
133133

134134
TEST(parsing_time_rfc1123_accepts_each_day)
135135
{
136-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:00 GMT"), (time_t) 0);
137-
TestRfc1123IsTimeT(_XPLATSTR("Fri, 02 Jan 1970 00:00:00 GMT"), (time_t) 86400 * 1);
138-
TestRfc1123IsTimeT(_XPLATSTR("Sat, 03 Jan 1970 00:00:00 GMT"), (time_t) 86400 * 2);
139-
TestRfc1123IsTimeT(_XPLATSTR("Sun, 04 Jan 1970 00:00:00 GMT"), (time_t) 86400 * 3);
140-
TestRfc1123IsTimeT(_XPLATSTR("Mon, 05 Jan 1970 00:00:00 GMT"), (time_t) 86400 * 4);
141-
TestRfc1123IsTimeT(_XPLATSTR("Tue, 06 Jan 1970 00:00:00 GMT"), (time_t) 86400 * 5);
142-
TestRfc1123IsTimeT(_XPLATSTR("Wed, 07 Jan 1970 00:00:00 GMT"), (time_t) 86400 * 6);
136+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:00 GMT"), (time_t)0);
137+
TestRfc1123IsTimeT(_XPLATSTR("Fri, 02 Jan 1970 00:00:00 GMT"), (time_t)86400 * 1);
138+
TestRfc1123IsTimeT(_XPLATSTR("Sat, 03 Jan 1970 00:00:00 GMT"), (time_t)86400 * 2);
139+
TestRfc1123IsTimeT(_XPLATSTR("Sun, 04 Jan 1970 00:00:00 GMT"), (time_t)86400 * 3);
140+
TestRfc1123IsTimeT(_XPLATSTR("Mon, 05 Jan 1970 00:00:00 GMT"), (time_t)86400 * 4);
141+
TestRfc1123IsTimeT(_XPLATSTR("Tue, 06 Jan 1970 00:00:00 GMT"), (time_t)86400 * 5);
142+
TestRfc1123IsTimeT(_XPLATSTR("Wed, 07 Jan 1970 00:00:00 GMT"), (time_t)86400 * 6);
143143
}
144144

145145
TEST(parsing_time_rfc1123_boundary_cases)
146146
{
147-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:00 GMT"), (time_t) 0);
148-
TestRfc1123IsTimeT(_XPLATSTR("19 Jan 2038 03:14:06 GMT"), (time_t) INT_MAX - 1);
149-
#ifndef _USE_32BIT_TIME_T
150-
TestRfc1123IsTimeT(_XPLATSTR("19 Jan 2038 03:13:07 -0001"), (time_t) INT_MAX);
151-
TestRfc1123IsTimeT(_XPLATSTR("19 Jan 2038 03:14:07 -0000"), (time_t) INT_MAX);
152-
#endif // _USE_32BIT_TIME_T
153-
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 +0000"), (time_t) 1547507781);
154-
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 -0001"), (time_t) 1547507841);
155-
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 +0001"), (time_t) 1547507721);
156-
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 -0100"), (time_t) 1547511381);
157-
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 +0100"), (time_t) 1547504181);
147+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:00 GMT"), (time_t)0);
148+
TestRfc1123IsTimeT(_XPLATSTR("19 Jan 2038 03:14:06 GMT"), (time_t)INT_MAX - 1);
149+
if (sizeof(time_t) == 8)
150+
{
151+
TestRfc1123IsTimeT(_XPLATSTR("19 Jan 2038 03:13:07 -0001"), (time_t)INT_MAX);
152+
TestRfc1123IsTimeT(_XPLATSTR("19 Jan 2038 03:14:07 -0000"), (time_t)INT_MAX);
153+
}
154+
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 +0000"), (time_t)1547507781);
155+
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 -0001"), (time_t)1547507841);
156+
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 +0001"), (time_t)1547507721);
157+
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 -0100"), (time_t)1547511381);
158+
TestRfc1123IsTimeT(_XPLATSTR("14 Jan 2019 23:16:21 +0100"), (time_t)1547504181);
158159
}
159160

160161
TEST(parsing_time_rfc1123_uses_each_field)
161162
{
162-
TestRfc1123IsTimeT(_XPLATSTR("02 Jan 1970 00:00:00 GMT"), (time_t) 86400);
163-
TestRfc1123IsTimeT(_XPLATSTR("12 Jan 1970 00:00:00 GMT"), (time_t) 950400);
164-
TestRfc1123IsTimeT(_XPLATSTR("01 Feb 1970 00:00:00 GMT"), (time_t) 2678400);
165-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 2000 00:00:00 GMT"), (time_t) 946684800);
166-
#ifndef _USE_32BIT_TIME_T
167-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 2100 00:00:00 GMT"), (time_t) 4102444800);
168-
#endif // _USE_32BIT_TIME_T
169-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1990 00:00:00 GMT"), (time_t) 631152000);
170-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1971 00:00:00 GMT"), (time_t) 31536000);
171-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 10:00:00 GMT"), (time_t) 36000);
172-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 01:00:00 GMT"), (time_t) 3600);
173-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:10:00 GMT"), (time_t) 600);
174-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:01:00 GMT"), (time_t) 60);
175-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:10 GMT"), (time_t) 10);
176-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:01 GMT"), (time_t) 1);
177-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 10:00:00 GMT"), (time_t) 36000);
178-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 02:00:00 PST"), (time_t) 36000);
179-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 03:00:00 PDT"), (time_t) 36000);
180-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 03:00:00 MST"), (time_t) 36000);
181-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 04:00:00 MDT"), (time_t) 36000);
182-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 04:00:00 CST"), (time_t) 36000);
183-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 05:00:00 CDT"), (time_t) 36000);
184-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 05:00:00 EST"), (time_t) 36000);
185-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 06:00:00 EDT"), (time_t) 36000);
186-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 06:00:00 -0400"), (time_t) 36000);
187-
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 05:59:00 -0401"), (time_t) 36000);
163+
TestRfc1123IsTimeT(_XPLATSTR("02 Jan 1970 00:00:00 GMT"), (time_t)86400);
164+
TestRfc1123IsTimeT(_XPLATSTR("12 Jan 1970 00:00:00 GMT"), (time_t)950400);
165+
TestRfc1123IsTimeT(_XPLATSTR("01 Feb 1970 00:00:00 GMT"), (time_t)2678400);
166+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 2000 00:00:00 GMT"), (time_t)946684800);
167+
if (sizeof(time_t) == 8)
168+
{
169+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 2100 00:00:00 GMT"), (time_t)4102444800);
170+
}
171+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1990 00:00:00 GMT"), (time_t)631152000);
172+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1971 00:00:00 GMT"), (time_t)31536000);
173+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 10:00:00 GMT"), (time_t)36000);
174+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 01:00:00 GMT"), (time_t)3600);
175+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:10:00 GMT"), (time_t)600);
176+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:01:00 GMT"), (time_t)60);
177+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:10 GMT"), (time_t)10);
178+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 00:00:01 GMT"), (time_t)1);
179+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 10:00:00 GMT"), (time_t)36000);
180+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 02:00:00 PST"), (time_t)36000);
181+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 03:00:00 PDT"), (time_t)36000);
182+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 03:00:00 MST"), (time_t)36000);
183+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 04:00:00 MDT"), (time_t)36000);
184+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 04:00:00 CST"), (time_t)36000);
185+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 05:00:00 CDT"), (time_t)36000);
186+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 05:00:00 EST"), (time_t)36000);
187+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 06:00:00 EDT"), (time_t)36000);
188+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 06:00:00 -0400"), (time_t)36000);
189+
TestRfc1123IsTimeT(_XPLATSTR("01 Jan 1970 05:59:00 -0401"), (time_t)36000);
188190
}
189191

190192
TEST(parsing_time_rfc1123_max_days)
191193
{
192-
TestRfc1123IsTimeT(_XPLATSTR("31 Jan 1970 00:00:00 GMT"), (time_t) 2592000);
193-
TestRfc1123IsTimeT(_XPLATSTR("28 Feb 2019 00:00:00 GMT"), (time_t) 1551312000); // non leap year allows feb 28
194-
TestRfc1123IsTimeT(_XPLATSTR("29 Feb 2020 00:00:00 GMT"), (time_t) 1582934400); // leap year allows feb 29
195-
TestRfc1123IsTimeT(_XPLATSTR("31 Mar 1970 00:00:00 GMT"), (time_t) 7689600);
196-
TestRfc1123IsTimeT(_XPLATSTR("30 Apr 1970 00:00:00 GMT"), (time_t) 10281600);
197-
TestRfc1123IsTimeT(_XPLATSTR("31 May 1970 00:00:00 GMT"), (time_t) 12960000);
198-
TestRfc1123IsTimeT(_XPLATSTR("30 Jun 1970 00:00:00 GMT"), (time_t) 15552000);
199-
TestRfc1123IsTimeT(_XPLATSTR("31 Jul 1970 00:00:00 GMT"), (time_t) 18230400);
200-
TestRfc1123IsTimeT(_XPLATSTR("31 Aug 1970 00:00:00 GMT"), (time_t) 20908800);
201-
TestRfc1123IsTimeT(_XPLATSTR("30 Sep 1970 00:00:00 GMT"), (time_t) 23500800);
202-
TestRfc1123IsTimeT(_XPLATSTR("31 Oct 1970 00:00:00 GMT"), (time_t) 26179200);
203-
TestRfc1123IsTimeT(_XPLATSTR("30 Nov 1970 00:00:00 GMT"), (time_t) 28771200);
204-
TestRfc1123IsTimeT(_XPLATSTR("31 Dec 1970 00:00:00 GMT"), (time_t) 31449600);
194+
TestRfc1123IsTimeT(_XPLATSTR("31 Jan 1970 00:00:00 GMT"), (time_t)2592000);
195+
TestRfc1123IsTimeT(_XPLATSTR("28 Feb 2019 00:00:00 GMT"), (time_t)1551312000); // non leap year allows feb 28
196+
TestRfc1123IsTimeT(_XPLATSTR("29 Feb 2020 00:00:00 GMT"), (time_t)1582934400); // leap year allows feb 29
197+
TestRfc1123IsTimeT(_XPLATSTR("31 Mar 1970 00:00:00 GMT"), (time_t)7689600);
198+
TestRfc1123IsTimeT(_XPLATSTR("30 Apr 1970 00:00:00 GMT"), (time_t)10281600);
199+
TestRfc1123IsTimeT(_XPLATSTR("31 May 1970 00:00:00 GMT"), (time_t)12960000);
200+
TestRfc1123IsTimeT(_XPLATSTR("30 Jun 1970 00:00:00 GMT"), (time_t)15552000);
201+
TestRfc1123IsTimeT(_XPLATSTR("31 Jul 1970 00:00:00 GMT"), (time_t)18230400);
202+
TestRfc1123IsTimeT(_XPLATSTR("31 Aug 1970 00:00:00 GMT"), (time_t)20908800);
203+
TestRfc1123IsTimeT(_XPLATSTR("30 Sep 1970 00:00:00 GMT"), (time_t)23500800);
204+
TestRfc1123IsTimeT(_XPLATSTR("31 Oct 1970 00:00:00 GMT"), (time_t)26179200);
205+
TestRfc1123IsTimeT(_XPLATSTR("30 Nov 1970 00:00:00 GMT"), (time_t)28771200);
206+
TestRfc1123IsTimeT(_XPLATSTR("31 Dec 1970 00:00:00 GMT"), (time_t)31449600);
205207
}
206208

207209
TEST(parsing_time_rfc1123_invalid_cases)
@@ -266,7 +268,7 @@ SUITE(datetime)
266268
_XPLATSTR("Thu, 01 Jan 1970 00:00:00 G"),
267269
_XPLATSTR("Thu, 01 Jan 1970 00:00:00 GM"),
268270
_XPLATSTR("Fri, 01 Jan 1970 00:00:00 GMT"), // wrong day
269-
_XPLATSTR("01 Jan 4970 00:00:00 GMT"), // year too big
271+
_XPLATSTR("01 Jan 4970 00:00:00 GMT"), // year too big
270272
_XPLATSTR("01 Jan 3001 00:00:00 GMT"),
271273
_XPLATSTR("01 Xxx 1971 00:00:00 GMT"), // month bad
272274
_XPLATSTR("00 Jan 1971 00:00:00 GMT"), // day too small
@@ -288,8 +290,8 @@ SUITE(datetime)
288290
_XPLATSTR("01 Jan 1971 00:60:00 GMT"), // minute too big
289291
_XPLATSTR("01 Jan 1971 00:00:70 GMT"), // second too big
290292
_XPLATSTR("01 Jan 1971 00:00:61 GMT"),
291-
_XPLATSTR("01 Jan 1969 00:00:00 GMT"), // underflow
292-
_XPLATSTR("01 Jan 1969 00:00:00 CEST"), // bad tz
293+
_XPLATSTR("01 Jan 1969 00:00:00 GMT"), // underflow
294+
_XPLATSTR("01 Jan 1969 00:00:00 CEST"), // bad tz
293295
_XPLATSTR("01 Jan 1970 00:00:00 +2400"), // bad tzoffsets
294296
_XPLATSTR("01 Jan 1970 00:00:00 -3000"),
295297
_XPLATSTR("01 Jan 1970 00:00:00 +2160"),
@@ -309,11 +311,12 @@ SUITE(datetime)
309311
// boundary cases:
310312
TestDateTimeRoundtrip(_XPLATSTR("1970-01-01T00:00:00Z")); // epoch
311313
TestDateTimeRoundtrip(_XPLATSTR("2038-01-19T03:14:06+00:00"), _XPLATSTR("2038-01-19T03:14:06Z")); // INT_MAX - 1
312-
#ifndef _USE_32BIT_TIME_T
313-
TestDateTimeRoundtrip(_XPLATSTR("2038-01-19T03:13:07-00:01"),
314-
_XPLATSTR("2038-01-19T03:14:07Z")); // INT_MAX after subtacting 1
315-
TestDateTimeRoundtrip(_XPLATSTR("2038-01-19T03:14:07-00:00"), _XPLATSTR("2038-01-19T03:14:07Z"));
316-
#endif // _USE_32BIT_TIME_T
314+
if (sizeof(time_t) == 8)
315+
{
316+
TestDateTimeRoundtrip(_XPLATSTR("2038-01-19T03:13:07-00:01"),
317+
_XPLATSTR("2038-01-19T03:14:07Z")); // INT_MAX after subtacting 1
318+
TestDateTimeRoundtrip(_XPLATSTR("2038-01-19T03:14:07-00:00"), _XPLATSTR("2038-01-19T03:14:07Z"));
319+
}
317320
}
318321

319322
TEST(parsing_time_iso8601_uses_each_timezone_digit)
@@ -456,11 +459,8 @@ SUITE(datetime)
456459
_XPLATSTR("1971-01-01T00:60:00Z"), // minute too big
457460
_XPLATSTR("1971-01-01T00:00:70Z"), // second too big
458461
_XPLATSTR("1971-01-01T00:00:61Z"),
459-
_XPLATSTR("1969-01-01T00:00:00Z"), // underflow
460-
#ifdef _USE_32BIT_TIME_T
461-
_XPLATSTR("3000-01-01T00:00:01Z"), // overflow
462-
#endif
463-
_XPLATSTR("3001-01-01T00:00:00Z"),
462+
_XPLATSTR("1969-01-01T00:00:00Z"), // underflow
463+
_XPLATSTR("3001-01-01T00:00:00Z"), // overflow
464464
_XPLATSTR("1970-01-01T00:00:00+00:01"), // time zone underflow
465465
// _XPLATSTR("1970-01-01T00:00:00.Z"), // accepted as invalid timezone above
466466
_XPLATSTR("1970-01-01T00:00:00+24:00"), // bad tzoffsets

0 commit comments

Comments
 (0)