Skip to content

Support Intl.NumberFormat.formatToParts in ES2018 #41299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saschanaz opened this issue Oct 28, 2020 · 5 comments
Closed

Support Intl.NumberFormat.formatToParts in ES2018 #41299

saschanaz opened this issue Oct 28, 2020 · 5 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone
Backlog

Comments

@saschanaz
Copy link
Contributor

TypeScript Version: Nightly

Search Terms:

Code

new Intl.NumberFormat().formatToParts

Expected behavior: Should be supported

Actual behavior: It requires ESNext

Playground Link: https://www.typescriptlang.org/play?target=5#code/HYUw7gBAksAuA2A6AcgVwLYCMQCcBiA9jugIawAUAlIgGZGmwAqBACiTrAM5A

See also https://github.com/tc39/proposals/blob/master/ecma402/finished-proposals.md
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Nov 10, 2020
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Nov 10, 2020
@sarathps93
Copy link

sarathps93 commented Nov 19, 2020 •
edited
Loading

Hi @RyanCavanaugh @saschanaz Is it ok if I work on this?

@saschanaz
Copy link
Contributor Author

Sure, I'm not working on this at least.

@rastenis rastenis mentioned this issue May 15, 2021
Closed
@rastenis
Copy link
Contributor

@RyanCavanaugh After moving Intl.NumberFormat.formatToParts to es2018.intl.d.ts, esnext.intl.d.ts remains empty. Should it be kept that way, or should it be removed completely?

@saschanaz
Copy link
Contributor Author

You can remove esnext.intl.d.ts and make esnext.intl point to es2018.intl.d.ts in src/compiler/commandLineParser.ts.

@rastenis rastenis mentioned this issue Jun 12, 2021
Closed
@MartinJohns MartinJohns mentioned this issue Aug 19, 2021
Closed
@orta
Copy link
Contributor

orta commented Sep 8, 2021

This is in with #45647 👍🏻

@orta orta closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(41299): Support Intl.NumberFormat.formatToParts in ES2018 rastenis/TypeScript
5 participants
@orta @saschanaz @RyanCavanaugh @rastenis @sarathps93