Skip to content

Optimize compile-on-save if for code bases with modules #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhegazy opened this issue May 18, 2015 · 3 comments
Closed

Optimize compile-on-save if for code bases with modules #3204

mhegazy opened this issue May 18, 2015 · 3 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented May 18, 2015

For code bases using modules, it would be safe to emit only modules and their dependencies, but not the whole solution.

Moreover, the --isolatedModules flag ensures that the output is safe to only emit a single file.

@mhegazy mhegazy added the Suggestion An idea for TypeScript label May 18, 2015
@mhegazy mhegazy added this to the TypeScript 1.6 milestone May 18, 2015
@mhegazy mhegazy added Visual Studio Integration with Visual Studio Bug A bug in TypeScript and removed Suggestion An idea for TypeScript labels May 18, 2015
@mhegazy mhegazy removed this from the TypeScript 1.6 milestone May 18, 2015
@mhegazy mhegazy added this to the TypeScript 1.6 milestone Jun 13, 2015
@mhegazy mhegazy self-assigned this Jun 13, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.7, TypeScript 1.6 Jul 1, 2015
@mhegazy mhegazy modified the milestones: TypeScript 2.0, TypeScript 1.7 Oct 6, 2015
@mhegazy mhegazy changed the title Optimize compile-on-save if --separateCompilation flag is set Optimize compile-on-save if --isolatedModules flag is set Oct 28, 2015
@mhegazy mhegazy assigned sheetalkamat and unassigned mhegazy Dec 1, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.8, TypeScript 2.0 Jan 7, 2016
@jonaskello
Copy link

I'm trying to do hot reloading with tsc -w but it seems impossible since all files are always updated, so the hot-reloader always reloads everything. Any news on this issue? Will it be in 2.0?

@mhegazy mhegazy changed the title Optimize compile-on-save if --isolatedModules flag is set Optimize compile-on-save if for code bases with modules May 5, 2016
@myitcv
Copy link

myitcv commented May 6, 2016

@alexeagle - presumably any Angular 2 app uses modules and so there would be significant benefit to your users if this change were to land?

@mhegazy - this is tagged as 'Visual Studio' but I don't think it's specific to either Visual Studio or "compile-on-save"?

@mhegazy
Copy link
Contributor Author

mhegazy commented Sep 29, 2016

This should be done in #9837

@mhegazy mhegazy closed this as completed Sep 29, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Sep 29, 2016
@mhegazy mhegazy assigned zhengbli and unassigned sheetalkamat Sep 29, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

5 participants