Starts to lag after editor-widget with large content pops up

[mjbvz]

From @emiljohansson on April 15, 2018 14:19

• VSCode Version: 1.22.2
• OS Version: macOS Sierra 10.12.6

Steps to Reproduce:

1. I am using JSS (9.0.0) in the screenshot example.
2. When adding a comma at the end of the line, within the createStyleSheet call, an element with the class name editor-widget pops up. The content of the box is 10001 characters long. It seems to be cut of after that, ending with "revert" | "unset…. Let me know if you want me to paste the content.

In the screenshot, the cursor start to lag when I navigate back and forth. Same when I navigate between editors.

Does this issue occur when all extensions are disabled?: Yes

Copied from original issue: microsoft/vscode#47909

[mjbvz]

From @emiljohansson on April 15, 2018 18:15

I wanted to add that if I close the widget, the lag remains going between editors, but the cursor lag seems to go away.

I also tested setting the end variable to 500 and that removed the lag: https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts#L394

[mjbvz]

Here's the code I tested this with:

import  jss from 'jss'

jss.createStyleSheet({
    base: {
        background: 'blue',
    }
})

Moving over the ts because the signature help requests themselves here seem to be taking a long time:

Rsponse received: signatureHelp (324). Request took 395 ms. Success: true 

Each one is between 350 and 500ms

[mhegazy]

Looks like we are spending most of the time serializing the union type..

[mhegazy]

looks like a duplicate of #23458. should be addressed by #23543

[typescript-bot]

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.