Skip to content

please make package.json version on github more useful #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clausreinke opened this issue Jan 27, 2015 · 9 comments
Closed

please make package.json version on github more useful #1818

clausreinke opened this issue Jan 27, 2015 · 9 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@clausreinke
Copy link

What is the suggested path for taking the github version of typescript as npm package dependency?

For instance, there are some small issues with the latest npm package 1.4.1, which are fixed in master, but master package.json still has version 1.4.0. So even if I npm install from the git repo, the version for the dependency can't be specified correctly.

My (naive?) suggestion would be:

  1. master version should always be at least as high as latest npm version
  2. add a build number to the version in master, and bump it every time the LKG is updated,

Btw, does anyone know how to specify a github dependency in package.json, without npm install being wasteful? Using

  "dependencies": "git+ssh://git@github.com:Microsoft/TypeScript.git"

npm (1.4.3) seems to clone the whole repo, when a shallow clone would be sufficient, and I don't want to think whether it is going to be more clever on updates. And while npm accepts tarballs, github offers zipfiles.

My best guess would be to specify the dependency with name and version only, then manually do something like

(cd ..;git clone --depth 1 git@github.com:Microsoft/TypeScript.git)
npm install ../TypeScript

If anyone has a good solution, that should perhaps go into the docs/readme somewhere?

@RyanCavanaugh
Copy link
Member

Welcome back Claus 😄

We've been talking about doing a rolling-build style thing on NPM and should roll the above recommendations into that.

@Arnavion
Copy link
Contributor

@clausreinke Meanwhile, you can use https://github.com/Arnavion/typescript-github

"dependencies": {
    "typescript-github": "https://github.com/Arnavion/typescript-github/tarball/2015-01-28-67023a83d520fe72cf723359198a931e36def0de"
}

@mhegazy
Copy link
Contributor

mhegazy commented Jan 30, 2015

@DanielRosenwasser just pump up the version to 1.5 everywhere.

@clausreinke
Copy link
Author

@mhegazy @DanielRosenwasser as long as version bump + fresh LKG always go together, that should help. If you don't like to spend a "real" version number for every build, add a build number.

(Since I raised concerns about npm github dependencies above: after the initial (too deep) clone, subsequent installs have been fast.)

@clausreinke
Copy link
Author

grmpf. Now that you've been so helpful, npm is driving me crazy: even though I've got typescript 1.5.0 installed globally, it refuses to accept that as a dependency, no matter what I try to convince it to ignore the registry. But that seems to be an npm bug: npm/npm#5509 (and no, the workaround doesn't for me).

@DanielRosenwasser
Copy link
Member

Labels:

  • bug
  • i-wanna-be-the-very-best

We should definitely adopt that label for some issues.

@DanielRosenwasser
Copy link
Member

Should we consider this Fixed now?

@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Feb 1, 2015
@clausreinke
Copy link
Author

submitter here: sure.

Is there a tracking issue for the npm build automation?

@DanielRosenwasser I wondered about the purpose of that label: since it isn't self-descriptive, it has the feeling of an inside joke.

@DanielRosenwasser
Copy link
Member

Is there a tracking issue for the npm build automation?

Not currently, I'll set one up.

Since it isn't self-descriptive, it has the feeling of an inside joke.

It's a Pokémon reference. The intro song starts off with the lyrics "I wanna be the very best". The tag is basically as if to say "this is a very hard task, you must be very determined to figure out a solution".

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

5 participants