Skip to content

Commit f690f05

Browse files
mhegazyDanielRosenwasser
authored andcommitted
Remove unused parameter to getCompletionsAtPosition
Conflicts: tests/baselines/reference/APISample_node_compile.js tests/baselines/reference/APISample_node_compile.types tests/baselines/reference/APISample_standalone_compile.js tests/baselines/reference/APISample_standalone_compile.types
1 parent 520979d commit f690f05

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/harness/fourslash.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -750,11 +750,11 @@ module FourSlash {
750750
}
751751

752752
private getMemberListAtCaret() {
753-
return this.languageService.getCompletionsAtPosition(this.activeFile.fileName, this.currentCaretPosition, true);
753+
return this.languageService.getCompletionsAtPosition(this.activeFile.fileName, this.currentCaretPosition);
754754
}
755755

756756
private getCompletionListAtCaret() {
757-
return this.languageService.getCompletionsAtPosition(this.activeFile.fileName, this.currentCaretPosition, false);
757+
return this.languageService.getCompletionsAtPosition(this.activeFile.fileName, this.currentCaretPosition);
758758
}
759759

760760
private getCompletionEntryDetails(entryName: string) {
@@ -1364,7 +1364,7 @@ module FourSlash {
13641364
this.languageService.getSignatureHelpItems(this.activeFile.fileName, offset);
13651365
} else if (prevChar === ' ' && /A-Za-z_/.test(ch)) {
13661366
/* Completions */
1367-
this.languageService.getCompletionsAtPosition(this.activeFile.fileName, offset, false);
1367+
this.languageService.getCompletionsAtPosition(this.activeFile.fileName, offset);
13681368
}
13691369

13701370
if (i % errorCadence === 0) {

src/services/services.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,7 @@ module ts {
895895
getSyntacticClassifications(fileName: string, span: TextSpan): ClassifiedSpan[];
896896
getSemanticClassifications(fileName: string, span: TextSpan): ClassifiedSpan[];
897897

898-
getCompletionsAtPosition(fileName: string, position: number, isMemberCompletion: boolean): CompletionInfo;
898+
getCompletionsAtPosition(fileName: string, position: number): CompletionInfo;
899899
getCompletionEntryDetails(fileName: string, position: number, entryName: string): CompletionEntryDetails;
900900

901901
getQuickInfoAtPosition(fileName: string, position: number): QuickInfo;
@@ -2666,7 +2666,7 @@ module ts {
26662666
};
26672667
}
26682668

2669-
function getCompletionsAtPosition(filename: string, position: number, isMemberCompletion: boolean) {
2669+
function getCompletionsAtPosition(filename: string, position: number) {
26702670
synchronizeHostData();
26712671

26722672
filename = normalizeSlashes(filename);
@@ -2741,7 +2741,7 @@ module ts {
27412741
if (isRightOfDot) {
27422742
// Right of dot member completion list
27432743
var symbols: Symbol[] = [];
2744-
isMemberCompletion = true;
2744+
var isMemberCompletion = true;
27452745

27462746
if (node.kind === SyntaxKind.Identifier || node.kind === SyntaxKind.QualifiedName || node.kind === SyntaxKind.PropertyAccessExpression) {
27472747
var symbol = typeInfoResolver.getSymbolAtLocation(node);

src/services/shims.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ module ts {
8888

8989
getSyntacticClassifications(fileName: string, start: number, length: number): string;
9090

91-
getCompletionsAtPosition(fileName: string, position: number, isMemberCompletion: boolean): string;
91+
getCompletionsAtPosition(fileName: string, position: number): string;
9292
getCompletionEntryDetails(fileName: string, position: number, entryName: string): string;
9393

9494
getQuickInfoAtPosition(fileName: string, position: number): string;
@@ -686,11 +686,11 @@ module ts {
686686
* to provide at the given source position and providing a member completion
687687
* list if requested.
688688
*/
689-
public getCompletionsAtPosition(fileName: string, position: number, isMemberCompletion: boolean) {
689+
public getCompletionsAtPosition(fileName: string, position: number) {
690690
return this.forwardJSONCall(
691-
"getCompletionsAtPosition('" + fileName + "', " + position + ", " + isMemberCompletion + ")",
691+
"getCompletionsAtPosition('" + fileName + "', " + position + ")",
692692
() => {
693-
var completion = this.languageService.getCompletionsAtPosition(fileName, position, isMemberCompletion);
693+
var completion = this.languageService.getCompletionsAtPosition(fileName, position);
694694
return completion;
695695
});
696696
}

0 commit comments

Comments
 (0)