Merge pull request #25 from microsoft/no-response-to-bot

Typescript-bot shouldnt reply to a PR it opened

Author: Orta Therox

src/anyRepoHandlePullRequest.ts

@@ -64,6 +64,7 @@ const generatePRInfo = async (api: Octokit, payload: WebhookPayloadPullRequest,
   return {
     thisIssue,
     authorIsMemberOfTSTeam,
+    authorIsTypescriptBot: payload.pull_request.user.login === "typescript-bot",
     relatedIssues,
     comments 
   }

src/checks/addCommentToUncommittedPRs.test.ts

@@ -25,6 +25,18 @@ describe(addCommentToUncommittedPRs, () => {
     expect(mockAPI.issues.removeLabel).not.toHaveBeenCalled()
   })
 
+  it("does not adds a comment to an uncommented, unlinked PR posted by typescript-bot", async () => {
+    const { mockAPI, api } = createMockGitHubClient()
+    mockAPI.issues.listComments.mockResolvedValue({ data: [] })
+    const pr = getPRFixture("opened")
+    pr.pull_request.user.login = "typescript-bot"
+
+    const info = createPRInfo({ authorIsTypescriptBot: true })
+    await addCommentToUncommittedPRs(api, pr, getFakeLogger(), info)
+
+    expect(mockAPI.issues.createComment).not.toHaveBeenCalled()
+  })
+
   it("Adds a comment to an uncommented PR linked to uncommitted suggestion", async () => {
     const { mockAPI, api } = createMockGitHubClient()
 

src/checks/addCommentToUncommittedPRs.ts

@@ -7,7 +7,7 @@ import type { PRInfo } from "../anyRepoHandlePullRequest"
  * Comment on new PRs that don't have linked issues, or link to uncommitted issues.
  */
 export const addCommentToUncommittedPRs = async (api: Octokit, payload: WebhookPayloadPullRequest, logger: Logger, info: PRInfo) => {
-  if (payload.pull_request.merged || payload.pull_request.draft || info.authorIsMemberOfTSTeam) {
+  if (payload.pull_request.merged || payload.pull_request.draft || info.authorIsMemberOfTSTeam || info.authorIsTypescriptBot) {
     return logger("Skipping") 
   }
 

src/util/tests/createPRInfo.ts

@@ -4,6 +4,7 @@ export const createPRInfo = (info?: Partial<PRInfo>): PRInfo => {
   return {
     comments: [],
     authorIsMemberOfTSTeam: false,
+    authorIsTypescriptBot: false,
     relatedIssues: [],
     thisIssue: {
       issue_number: 35454,