feat: change env variables to arg flags

Author: meabed

Dockerfile.in

@@ -22,10 +22,10 @@ RUN apk update \
     && update-ca-certificates
 
 ADD bin/ARG_OS-ARG_ARCH/ARG_SRC_BIN /ARG_BIN
+ENV BINSRC_ENV="/ARG_BIN"
 COPY scripts/docker-entrypoint.sh /usr/local/bin/
 
 EXPOSE 5000
 
 USER nobody:nobody
 ENTRYPOINT ["docker-entrypoint.sh"]
-CMD ["/ARG_BIN"]

Procfile

@@ -1 +1 @@
-web: P=$PORT CACHE=$CACHE_ENV STATIC_PATH=/app/cmd/server/public ./bin/server
+web: ./bin/server - P=$PORT -CACHE=$CACHE_ENV -STATIC_PATH=/app/cmd/server/public

cmd/server/helpers.go

@@ -7,14 +7,6 @@ import (
 	"path/filepath"
 )
 
-// GetEnv ... get value from env variables or return the fallback value
-func GetEnv(key, fallback string) string {
-	if value, ok := os.LookupEnv(key); ok {
-		return value
-	}
-	return fallback
-}
-
 // LsFiles ... list file in directory
 func LsFiles(pattern string) {
 	err := filepath.Walk(pattern,

cmd/server/helpers_test.go

@@ -1,9 +1,2 @@
 package main
 
-import (
-	"testing"
-)
-
-func TestGetEnv(t *testing.T) {
-
-}

cmd/server/main.go

@@ -11,15 +11,14 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
-	"strconv"
 	"time"
 )
 
 var (
-	host        string
-	port        int
-	cacheDriver string
-	redisUrl    string
+	host        *string
+	port        *int
+	cacheDriver *string
+	redisUrl    *string
 	// Storage ... Server Cache Storage
 	Storage cache.Storage
 	// Logger ... Logger Driver
@@ -32,10 +31,9 @@ var (
 	routes = map[string]func(w http.ResponseWriter, r *http.Request){
 		`/convert`: Convert,
 	}
-
 	_, filename, _, _ = runtime.Caller(0)
 	defaultStaticPath = filepath.Dir(filename) + `/public`
-	staticPath        = defaultStaticPath
+	staticPath        = &defaultStaticPath
 )
 
 // init ... init function of the server
@@ -50,19 +48,19 @@ func init() {
 	logging.SetBackend(backendLevelFormatted)
 
 	// Caching
-	host = GetEnv(`H`, `0.0.0.0`)
-	port, _ = strconv.Atoi(GetEnv(`P`, `5000`))
-	cacheDriver = GetEnv(`CACHE`, `memory`)
-	redisUrl = GetEnv(`REDIS_URL`, ``)
-	staticPath = GetEnv(`STATIC_PATH`, defaultStaticPath)
+	host = flag.String(`H`, `0.0.0.0`, `Host binding address`)
+	port = flag.Int(`P`, 5000, `Host binding port`)
+	cacheDriver = flag.String(`CACHE`, `memory`, `Cache driver (default memory)`)
+	redisUrl = flag.String(`REDIS_URL`, ``, `Redis URI for redis cache driver`)
+	staticPath = flag.String(`STATIC_PATH`, defaultStaticPath, `Webserver static path`)
 
 	flag.Parse()
 
 	var err error
 
-	switch cacheDriver {
+	switch *cacheDriver {
 	case `redis`:
-		if Storage, err = redis.NewStorage(redisUrl); err != nil {
+		if Storage, err = redis.NewStorage(*redisUrl); err != nil {
 			Logger.Panic(err)
 		}
 		break
@@ -75,18 +73,18 @@ func init() {
 // main ... main function start the server
 func main() {
 
-	Logger.Infof("host %s", host)
-	Logger.Infof("port %d", port)
-	Logger.Infof("cacheDriver %s", cacheDriver)
-	Logger.Infof("REDIS_URL %s", redisUrl)
-	Logger.Infof("Static dir %s", staticPath)
+	Logger.Infof("host %s", *host)
+	Logger.Infof("port %d", *port)
+	Logger.Infof("cacheDriver %s", *cacheDriver)
+	Logger.Infof("REDIS_URL %s", *redisUrl)
+	Logger.Infof("Static dir %s", *staticPath)
 
 	// handle routers
 	for k, v := range routes {
 		http.HandleFunc(k, v)
 	}
 
-	go serveHTTP(host, port)
+	go serveHTTP(*host, *port)
 	select {}
 }
 
@@ -96,7 +94,7 @@ func serveHTTP(host string, port int) {
 	mux := http.NewServeMux()
 	for k, v := range routes {
 		mux.HandleFunc(k, v)
-		mux.Handle(`/`, http.FileServer(http.Dir(staticPath)))
+		mux.Handle(`/`, http.FileServer(http.Dir(*staticPath)))
 	}
 
 	addr := fmt.Sprintf("%v:%d", host, port)

scripts/docker-entrypoint.sh

@@ -1,6 +1,7 @@
 #!/bin/sh
 
 echo Your container args are: "$@"
+echo Your BINSRC_ENV are: "${BINSRC_ENV}"
 
-exec "$@"
+exec ${BINSRC_ENV} "$@"
 

scripts/server-redis.sh

@@ -7,4 +7,5 @@ set -o pipefail
 my_dir="$(dirname "$0")"
 
 GO_FILES=`find ${my_dir}/../cmd/server/. -type f \( -iname "*.go" ! -iname "*_test.go" \)`
-REDIS_URL=redis://localhost:6379 CACHE=redis go run ${GO_FILES}
+cmd="go run ${GO_FILES} -CACHE=redis -REDIS_URL=redis://localhost:6379"
+${cmd}