fix: handle 0 exchange rates incase of json response are not correct.

Author: meabed

pkg/exchanger/1forge.go

@@ -94,6 +94,9 @@ func (c *oneForgeApi) Latest(from string, to string, opt ...interface{}) error {
 	value := json.GetPath(`value`).
 		MustFloat64()
 	// todo handle error
+	if value <= 0 {
+		return fmt.Errorf(`error in retrieving exhcange rate is 0`)
+	}
 	c.rateValue = value
 	c.rateDate = time.Now()
 	return nil

pkg/exchanger/currencylayer.go

@@ -94,6 +94,9 @@ func (c *currencyLayerApi) Latest(from string, to string, opt ...interface{}) er
 	value := json.GetPath(`result`).
 		MustFloat64()
 	// todo handle error
+	if value <= 0 {
+		return fmt.Errorf(`error in retrieving exhcange rate is 0`)
+	}
 	c.rateValue = value
 	c.rateDate = time.Now()
 	return nil

pkg/exchanger/fixer.go

@@ -71,7 +71,6 @@ func (c *fixerApi) GetExchangerName() string {
 // Latest ... populate latest exchange rate
 func (c *fixerApi) Latest(from string, to string, opt ...interface{}) error {
 
-	// todo cache layer
 	_, err := c.requestRate(from, to, opt)
 	if err != nil {
 		log.Print(err)
@@ -95,7 +94,11 @@ func (c *fixerApi) Latest(from string, to string, opt ...interface{}) error {
 	value := json.GetPath(`result`).
 		MustFloat64()
 	// todo handle error
+	if value <= 0 {
+		return fmt.Errorf(`error in retrieving exhcange rate is 0`)
+	}
 	c.rateValue = value
+	c.rateDate = time.Now()
 	return nil
 }
 

pkg/exchanger/openexchangerates.go

@@ -94,6 +94,9 @@ func (c *openExchangeRatesApi) Latest(from string, to string, opt ...interface{}
 	value := json.GetPath(`response`).
 		MustFloat64()
 	// todo handle error
+	if value <= 0 {
+		return fmt.Errorf(`error in retrieving exhcange rate is 0`)
+	}
 	c.rateValue = value
 	c.rateDate = time.Now()
 	return nil

pkg/exchanger/yahoo.go

@@ -98,6 +98,9 @@ func (c *yahooApi) Latest(from string, to string, opt ...interface{}) error {
 		GetIndex(0).
 		MustFloat64()
 	// todo handle error
+	if value <= 0 {
+		return fmt.Errorf(`error in retrieving exhcange rate is 0`)
+	}
 	c.rateValue = math.Round(value*1000000) / 1000000
 	c.rateDate = time.Now()
 	return nil