Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Commit d4918b8

Browse files
Backup and restore go.mod & go.sum during linting (#735)
Every time before sending a PR I like to run ./scripts/build-test-lint.sh to make sure the CI won't complain about anything. The problem is that this script attempts to install golangci-lint, which causes modifications to go.mod/go.sum. This PR backs up and restores those files before and after linting. Ideally instead of this hacky backing up/restoring we'd use go gets -mod=readonly option, but that still modifies go.sum. This will be fixed in go 1.13 apparently. golang/go#30667
1 parent 86e65bb commit d4918b8

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

scripts/find-lint.sh

+8
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,15 @@ then args="--fast"
2222
fi
2323

2424
echo "Installing golangci-lint..."
25+
26+
# Make a backup of go.{mod,sum} first
27+
# TODO: Once go 1.13 is out, use go get's -mod=readonly option
28+
# https://github.com/golang/go/issues/30667
29+
cp go.mod go.mod.bak && cp go.sum go.sum.bak
2530
go get github.com/golangci/golangci-lint/cmd/golangci-lint
2631

2732
echo "Looking for lint..."
2833
golangci-lint run $args
34+
35+
# Restore go.{mod,sum}
36+
mv go.mod.bak go.mod && mv go.sum.bak go.sum

0 commit comments

Comments
 (0)