Skip to content

Data changes aren't animating #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaxAst opened this issue Oct 18, 2024 · 2 comments · May be fixed by #111
Closed

Data changes aren't animating #115

MaxAst opened this issue Oct 18, 2024 · 2 comments · May be fixed by #111

Comments

@MaxAst
Copy link

MaxAst commented Oct 18, 2024 •
edited
Loading

Thanks for this great library! Everything's been working well, apart from the animation on data changes demonstrated in the gifs of the README. I provided a repro using Expo Go here, using the code from your example. Likely caused by different skia versions, I'm using the latest one in my example

ScreenRecording_10-18-2024.07-13-53_1.MP4
@billyjacoby
Copy link

billyjacoby commented Oct 23, 2024 •
edited
Loading

Seeing the same issue on my end as well. I've tried with both the latest version - 1.5.0 as well as 1.2.3 and 0.1.233

@MaxAst
Copy link
Author

MaxAst commented Oct 23, 2024

I changed to victory and in their docs it says that skia animations only work if the data points length is the same across ranges. Might be the same for this library

@MaxAst MaxAst closed this as completed Oct 23, 2024
@msalcala11 msalcala11 mentioned this issue Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: animate graph on data changes msalcala11/react-native-graph
2 participants
@MaxAst @billyjacoby