Skip to content

Exception #0 (ReflectionException): Class "***********************" does not exist. Wrong logic. #38480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
Genaker opened this issue Feb 28, 2024 · 6 comments · May be fixed by #39819
Open
5 tasks
Assignees
Labels
Area: Framework Component: Eav Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@Genaker
Copy link

Genaker commented Feb 28, 2024

Preconditions and environment

Magento 2 Core all versions have a core issue. When the source model of the EAV class from the Database does not exist magento throws

ReflectionException

Exception #0 (ReflectionException): Class "**\Model\Config\Source***\Options" does not exist

/var/www/html/magento/vendor/magento/framework/Code/Reader/ClassReader.php

 public function getConstructor($className)
    {
        $class = new ReflectionClass($className); <-- Exception happens here 

however, it has logic to tell you exactly what attribute Model is missing

/var/www/html/magento/vendor/magento/module-eav/Model/Entity/Attribute/AbstractAttribute.php

public function getSource()
    {
        if (empty($this->_source)) {
            if (!$this->getSourceModel()) {
                $this->_source = $this->_getDefaultSourceModel();
            } else {
                $this->_source = $this->getSourceModel();
            }
        
            if (!$source) {
                throw new LocalizedException(
                    __(
                        'Source model "%1" not found for attribute "%2"',
                        $this->getSourceModel(),
                        $this->getAttributeCode()
                    )
                );
            }

but this logic never happens because it is an Exception(ReflectionException) not a bool value

you need to add this code and check exception

public function getSource()
{
if (empty($this->_source)) {
if (!$this->getSourceModel()) {
$this->_source = $this->_getDefaultSourceModel();
} else {
$this->_source = $this->getSourceModel();
}
try {
$source = $this->_universalFactory->create($this->_source);
} catch (\ReflectionException $e) {
$source = false;
}
if (!$source) {
throw new LocalizedException(
__(
'Source model "%1" not found for attribute "%2"',
$this->getSourceModel(),
$this->getAttributeCode()
)
);
}

then an exception will be self-explained:

Exception #0 (Magento\Framework\Exception\LocalizedException): Source model "*****\Model\Config\Source*\Options" not found for attribute "some_attribute"

Please fix it ASAP.

Related issue: #30278

Steps to reproduce

  • Create a custom product attribute programmatically with dropdown type.
  • Don't create a source class for the attribute.
  • Try to open a product in admin panel.
  • ReflectionException is thrown.

Expected result

Normal Exception explanation

Exception #0 (Magento\Framework\Exception\LocalizedException): Source model "*****\Model\Config\Source*\Options" not found for attribute "some_attribute"

Actual result

Exception #0 (ReflectionException): Class "***********************" does not exist.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Feb 28, 2024

Hi @Genaker. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Feb 29, 2024
@engcom-November engcom-November self-assigned this Feb 29, 2024
Copy link

m2-assistant bot commented Feb 29, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @Genaker,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop.
When the source model is missing from a custom product attribute, we are seeing the below reflection exception
Class "Vendor\Module\Model\Config\Source\Options" does not exist.
But there is already a LocalizedException present for such case, but this logic is not being triggered, as the $source variable is always true in \Magento\Eav\Model\Entity\Attribute\AbstractAttribute::getSource.

Please take a look at the screenshot below:
We are getting the below error
image

Instead, we should have received something like this.
image

Hence Confirming the issue.

Please find the custom module used to reproduce the issue.
AttVendor.zip

Thank you.

@engcom-November engcom-November added Component: Eav Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework labels Feb 29, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11469 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Feb 29, 2024

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 5, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
@Sathakathulla-S
Copy link

@magento I'm working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Eav Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants