Skip to content

Commit a051023

Browse files
authored
Merge pull request #26 from machow/fix-column-later-desc-sort
fix: column default_sort_order respected when resorting
2 parents 5072072 + 80b2b61 commit a051023

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

reactable/models.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -696,6 +696,9 @@ class Column:
696696
footer_style: CssRules | None = None
697697
id: str | None = None
698698

699+
# props ----
700+
default_sort_desc: bool = field(init=False)
701+
699702
# internal ----
700703
# TODO: ideally this cannot be specified in the constructor
701704
# it's just passed to the widget
@@ -714,6 +717,8 @@ def __post_init__(self):
714717
aggregated=self.format.to_props(),
715718
)
716719

720+
self.default_sort_desc = self.default_sort_order == "desc"
721+
717722
def _apply_transform(self, col_data: list[Any], transform: callable):
718723
return [
719724
to_hydrate_format(transform(CellInfo(val, ii, self.id)))
@@ -790,7 +795,9 @@ def merge(self, other: Column | None):
790795
if other is None:
791796
return self
792797

793-
field_attrs = {field.name: getattr(self, field.name) for field in fields(self)}
798+
field_attrs = {
799+
field.name: getattr(self, field.name) for field in fields(self) if field.init
800+
}
794801
return replace(other, **filter_none(field_attrs))
795802

796803
def to_props(self) -> dict[str, Any]:

0 commit comments

Comments
 (0)