Skip to content

Commit f862265

Browse files
authored
AMDGPU: Use True16Predicate for UseRealTrue16Insts in VOP2 Reals (#84394)
We can not use OtherPredicates or SubtargetPredicate because they should be copied from pseudo to real, and we should not override them.
1 parent 293ec48 commit f862265

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

llvm/lib/Target/AMDGPU/VOP2Instructions.td

+3-3
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class VOP2_Real <VOP2_Pseudo ps, int EncodingFamily, string real_name = ps.Mnemo
112112
class VOP2_Real_Gen <VOP2_Pseudo ps, GFXGen Gen, string real_name = ps.Mnemonic> :
113113
VOP2_Real <ps, Gen.Subtarget, real_name> {
114114
let AssemblerPredicate = Gen.AssemblerPredicate;
115-
let OtherPredicates = !if(ps.Pfl.IsRealTrue16, [UseRealTrue16Insts], []);
115+
let True16Predicate = !if(ps.Pfl.IsRealTrue16, UseRealTrue16Insts, NoTrue16Predicate);
116116
let DecoderNamespace = Gen.DecoderNamespace#
117117
!if(ps.Pfl.IsRealTrue16, "", "_FAKE16");
118118
}
@@ -1272,7 +1272,7 @@ class VOP2_DPP16_Gen<bits<6> op, VOP2_DPP_Pseudo ps, GFXGen Gen,
12721272
string opName = ps.OpName, VOPProfile p = ps.Pfl> :
12731273
VOP2_DPP16<op, ps, Gen.Subtarget, opName, p> {
12741274
let AssemblerPredicate = Gen.AssemblerPredicate;
1275-
let OtherPredicates = !if(ps.Pfl.IsRealTrue16, [UseRealTrue16Insts], []);
1275+
let True16Predicate = !if(ps.Pfl.IsRealTrue16, UseRealTrue16Insts, NoTrue16Predicate);
12761276
let DecoderNamespace = Gen.DecoderNamespace#
12771277
!if(ps.Pfl.IsRealTrue16, "", "_FAKE16");
12781278
}
@@ -1301,7 +1301,7 @@ class VOP2_DPP8_Gen<bits<6> op, VOP2_Pseudo ps, GFXGen Gen,
13011301
VOPProfile p = ps.Pfl> :
13021302
VOP2_DPP8<op, ps, p> {
13031303
let AssemblerPredicate = Gen.AssemblerPredicate;
1304-
let OtherPredicates = !if(ps.Pfl.IsRealTrue16, [UseRealTrue16Insts], []);
1304+
let True16Predicate = !if(ps.Pfl.IsRealTrue16, UseRealTrue16Insts, NoTrue16Predicate);
13051305
let DecoderNamespace = Gen.DecoderNamespace#
13061306
!if(ps.Pfl.IsRealTrue16, "", "_FAKE16");
13071307
}

0 commit comments

Comments
 (0)