Display a warning when provisioning scripts use LIMA_CIDATA variables

jandubois · jandubois · commit 764d5df7c588 · 2024-01-09T16:44:22.000-08:00
Signed-off-by: Jan Dubois &lt;jan.dubois@suse.com&gt;
diff --git a/pkg/limayaml/validate.go b/pkg/limayaml/validate.go
@@ -187,6 +187,9 @@ func Validate(y LimaYAML, warn bool) error {
 			return fmt.Errorf("field `provision[%d].mode` must one of %q, %q, %q, or %q",
 				i, ProvisionModeSystem, ProvisionModeUser, ProvisionModeBoot, ProvisionModeDependency)
 		}
+		if strings.Contains(p.Script, "LIMA_CIDATA") {
+			logrus.Warn("provisioning scripts should not reference the LIMA_CIDATA variables")
+		}
 	}
 	needsContainerdArchives := (y.Containerd.User != nil && *y.Containerd.User) || (y.Containerd.System != nil && *y.Containerd.System)
 	if needsContainerdArchives && len(y.Containerd.Archives) == 0 {

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,9 @@ func Validate(y LimaYAML, warn bool) error {`
`187`	`187`	return fmt.Errorf("field `provision[%d].mode` must one of %q, %q, %q, or %q",
`188`	`188`	`i, ProvisionModeSystem, ProvisionModeUser, ProvisionModeBoot, ProvisionModeDependency)`
`189`	`189`	`}`
	`190`	`+ if strings.Contains(p.Script, "LIMA_CIDATA") {`
	`191`	`+ logrus.Warn("provisioning scripts should not reference the LIMA_CIDATA variables")`
	`192`	`+ }`
`190`	`193`	`}`
`191`	`194`	`needsContainerdArchives := (y.Containerd.User != nil && y.Containerd.User) \|\| (y.Containerd.System != nil && y.Containerd.System)`
`192`	`195`	`if needsContainerdArchives && len(y.Containerd.Archives) == 0 {`