fix: clear the registrar when libp2p stops

Author: jacobheun

src/index.js

@@ -187,6 +187,7 @@ class Libp2p extends EventEmitter {
       this.pubsub && await this.pubsub.stop()
       this._dht && await this._dht.stop()
       await this.transportManager.close()
+      await this.registrar.close()
     } catch (err) {
       if (err) {
         log.error(err)

src/registrar.js

@@ -46,6 +46,23 @@ class Registrar {
     this._handle = handle
   }
 
+  /**
+   * Cleans up the registrar
+   * @async
+   */
+  async close () {
+    // Close all connections we're tracking
+    const tasks = []
+    for (const connectionList of this.connections.values()) {
+      for (const connection of connectionList) {
+        tasks.push(connection.close())
+      }
+    }
+
+    await tasks
+    this.connections.clear()
+  }
+
   /**
    * Add a new connected peer to the record
    * TODO: this should live in the ConnectionManager

test/registrar/registrar.node.js

@@ -54,4 +54,19 @@ describe('registrar on dial', () => {
     const remoteConn = remoteLibp2p.registrar.getConnection(peerInfo)
     expect(remoteConn).to.exist()
   })
+
+  it('should be closed on libp2p stop', async () => {
+    libp2p = new Libp2p(mergeOptions(baseOptions, {
+      peerInfo
+    }))
+
+    await libp2p.dial(remoteAddr)
+    expect(libp2p.registrar.connections.size).to.equal(1)
+
+    sinon.spy(libp2p.registrar, 'close')
+
+    await libp2p.stop()
+    expect(libp2p.registrar.close.callCount).to.equal(1)
+    expect(libp2p.registrar.connections.size).to.equal(0)
+  })
 })