Skip to content

Commit a2421e8

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent cbaeb47 commit a2421e8

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

+7-2
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
428428
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
429429
Linkage = GlobalValue::LinkOnceODRLinkage;
430430
else if (Linkage == GlobalValue::InternalLinkage ||
431-
Linkage == GlobalValue::ExternalLinkage)
432-
Linkage = GlobalValue::PrivateLinkage;
431+
Linkage == GlobalValue::ExternalLinkage) {
432+
// LDC: use internal instead of private linkage for COFF (still local, but
433+
// allows for COMDATs on Windows)
434+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
435+
? GlobalValue::InternalLinkage
436+
: GlobalValue::PrivateLinkage;
437+
}
433438

434439
auto *Value =
435440
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)