fix: Remove invalid prereq check_variation_range check
#261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing flag payload information, the SDK attempts to pre-check several failure conditions. One of those conditions was to ensure that a provided prereq has a valid variation index. However, the system cannot actually perform this check at parse time since the prerequisite flag might not have been parsed yet. As this check served only as a nice to have, I have removed it and added a test verifying the prereq behavior still operates as expected. Fixes #260
|
This pull request has been linked to Shortcut Story #237484: Fix prereq range check. |
kinyoklion
approved these changes
Mar 25, 2024
keelerm84
added a commit
that referenced
this pull request
Mar 28, 2024
When parsing flag payload information, the SDK attempts to pre-check several failure conditions. One of those conditions was to ensure that a provided prereq has a valid variation index. However, the system cannot actually perform this check at parse time since the prerequisite flag might not have been parsed yet. As this check served only as a nice to have, I have removed it and added a test verifying the prereq behavior still operates as expected. Fixes #260
keelerm84
pushed a commit
that referenced
this pull request
Mar 28, 2024
🤖 I have created a release *beep* *boop* --- ## [7.3.3](7.3.2...7.3.3) (2024-03-28) ### Bug Fixes * Remove invalid prereq `check_variation_range` check ([#261](#261)) ([960e392](960e392)), closes [#260](#260) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
keelerm84
added a commit
that referenced
this pull request
Mar 28, 2024
When parsing flag payload information, the SDK attempts to pre-check several failure conditions. One of those conditions was to ensure that a provided prereq has a valid variation index. However, the system cannot actually perform this check at parse time since the prerequisite flag might not have been parsed yet. As this check served only as a nice to have, I have removed it and added a test verifying the prereq behavior still operates as expected. Fixes #260
keelerm84
pushed a commit
that referenced
this pull request
Mar 28, 2024
🤖 I have created a release *beep* *boop* --- ## [8.3.1](8.3.0...8.3.1) (2024-03-28) ### Bug Fixes * Ensure Rails.logger exists before using it ([#258](#258)) ([2f0f7ed](2f0f7ed)) * Remove invalid prereq `check_variation_range` check ([#261](#261)) ([#263](#263)) ([74ca206](74ca206)), closes [#260](#260) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing flag payload information, the SDK attempts to pre-check several failure conditions. One of those conditions was to ensure that a provided prereq has a valid variation index.
However, the system cannot actually perform this check at parse time since the prerequisite flag might not have been parsed yet.
As this check served only as a nice to have, I have removed it and added a test verifying the prereq behavior still operates as expected.
Fixes #260