Skip to content

Compatibility problem in 2.10.0 due to use of Promise.finally() #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eli-darkly opened this issue Apr 23, 2019 · 4 comments
Closed

Compatibility problem in 2.10.0 due to use of Promise.finally() #151

eli-darkly opened this issue Apr 23, 2019 · 4 comments

Comments

@eli-darkly
Copy link
Contributor

It's come to our attention that the 2.10.0 release is incompatible with some older browsers because it uses the finally() method of Promise, which was a more recent addition to the Promise standard.

We apologize for the mistake, and we will release a patch shortly that fixes this.

@eli-darkly
Copy link
Contributor Author

We have released version 2.10.1, which fixes this issue. Note that while the new version should be available immediately via npm, there is a delay before the copy hosted at https://app.launchdarkly.com/snippet/ldclient.min.js will be on the new version; we will update this as soon as possible.

@PerStirpes
Copy link

EdgeHTML Platform Status

finally is currently in development

@eli-darkly
Copy link
Contributor Author

@PerStirpes Yes, I should've said "older browsers and also Edge." Unfortunately, some commonly used Promise polyfills don't support it either, so people who knew they would need to use a polyfill to support older browsers that didn't have native Promise support would still be out of luck.

@eli-darkly
Copy link
Contributor Author

There was a delay in updating https://app.launchdarkly.com/snippet/ldclient.min.js but the fix is there too now.

LaunchDarklyCI pushed a commit that referenced this issue Nov 6, 2019
remove Electron from the electron branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants