Merge pull request #159 from launchdarkly/eb/ch31228/stream-delete-error

fix error on out-of-order delete

Author: eli-darkly

packages/ldclient-js-common/src/__tests__/LDClient-streaming-test.js

@@ -564,6 +564,42 @@ describe('LDClient', () => {
       });
     });
 
+    it('handles delete message for unknown flag by storing placeholder', done => {
+      const client = platform.testing.makeClient(envName, user, { bootstrap: {} });
+
+      client.on('ready', () => {
+        client.on('change', () => {});
+
+        streamEvents().delete({
+          data: '{"key":"mystery","version":3}',
+        });
+
+        // The following patch message should be ignored because it has a lower version than the deleted placeholder
+        streamEvents().patch({
+          data: '{"key":"mystery","value":"yes","version":2}',
+        });
+
+        expect(client.variation('mystery')).toBeUndefined();
+        done();
+      });
+    });
+
+    it('ignores delete message with lower version', done => {
+      const bootstrapData = { flag: 'yes', $flagsState: { flag: { version: 3 } } };
+      const client = platform.testing.makeClient(envName, user, { bootstrap: bootstrapData });
+
+      client.on('ready', () => {
+        client.on('change', () => {});
+
+        streamEvents().delete({
+          data: '{"key":"flag","version":2}',
+        });
+
+        expect(client.variation('flag')).toEqual('yes');
+        done();
+      });
+    });
+
     it('fires global change event when flag is deleted', done => {
       const client = platform.testing.makeClient(envName, user, { bootstrap: { 'enable-foo': true } });
 

packages/ldclient-js-common/src/messages.js

@@ -107,7 +107,7 @@ export const debugStreamDelete = function(key) {
   return 'received streaming deletion for flag "' + key + '"';
 };
 
-export const debugStreamingDeleteIgnored = function(key) {
+export const debugStreamDeleteIgnored = function(key) {
   return 'received streaming deletion for flag "' + key + '" but ignored due to version check';
 };