Use extend-expect directly from jest-dom #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapse
commented
Jul 10, 2018
package.json
Outdated
| @@ -35,8 +35,7 @@ | |||
| }, | |||
| "files": [ | |||
| "dist", | |||
| "typings", | |||
| "extend-expect.js" | |||
| "typings" | |||
| ], | |||
| "dependencies": { | |||
| "jest-dom": "^1.0.0", | |||
There was a problem hiding this comment.
Now that I think about it, maybe jest-dom ceases to be a dependency and has to be moved to devDependencies instead, right?
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
alexkrolick
pushed a commit
to alexkrolick/dom-testing-library
that referenced
this pull request
Sep 13, 2018
…ary#70) * feat(rerender): implement rerender (testing-library#65) * update readme * update examples * tests * typescript typings * Update index.js * Update rerender.js * Update rerender.js * Update README.md Closes testing-library#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove extend-expect from this library.
Why:
Users should directly import the same functionality from jest-dom
How:
Removing the file and changing the documentation around it, and its reference from package.json
Checklist:
Closes #69