Pr/unofficially support node 6 #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
🎉 This PR is included in version 3.12.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Unofficially support node 6 by changing
Object.entriestoObject.keysWhy:
I opened a PR to jest that adds an example for testing with
react-testing-library.jest runs it's test suite against node 6 (including the example I added), which is failing because of the call to
Object.entries.Switching to
Object.keysshould make the test pass so the PR can be merged 😸See tweet from @kentcdodds: https://twitter.com/kentcdodds/status/1060735136172466176
How:
With code 😸
Checklist:
async)