added attribute to QueryByAttribute and AllByAttribute #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added attribute argument to type
QueryByAttributeandAllByAttributeWhy:
This argument seems to be falsely missing.
Usage of
AllByAttributecan bee seen here:https://github.com/BenjaminEckardt/dom-testing-library/blob/master/src/queries.js#L60
Usage of
QueryByAttributeis a bit less obvious due to currying but can be seen here:https://github.com/kentcdodds/dom-testing-library/blob/master/src/queries.js#L153
How:
Just added the missing attribute.
Checklist: