Skip to content

Commit 2d36062

Browse files
committed
Remove unnecessary authority comparison.
Issue: spring-projectsgh-7035
1 parent 0fea2fb commit 2d36062

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ private void buildRolesReachableInOneStepMap() {
192192
} else {
193193
rolesReachableInOneStepSet = this.rolesReachableInOneStepMap.get(higherRole);
194194
}
195-
addReachableRoles(rolesReachableInOneStepSet, lowerRole);
195+
rolesReachableInOneStepSet.add(lowerRole);
196196
if (logger.isDebugEnabled()) {
197197
logger.debug("buildRolesReachableInOneStepMap() - From role " + higherRole
198198
+ " one can reach role " + lowerRole + " in one step.");
@@ -227,7 +227,7 @@ private void buildRolesReachableInOneOrMoreStepsMap() {
227227
// take a role from the rolesToVisit set
228228
GrantedAuthority aRole = rolesToVisitSet.iterator().next();
229229
rolesToVisitSet.remove(aRole);
230-
addReachableRoles(visitedRolesSet, aRole);
230+
visitedRolesSet.add(aRole);
231231
if (this.rolesReachableInOneStepMap.containsKey(aRole)) {
232232
Set<GrantedAuthority> newReachableRoles = this.rolesReachableInOneStepMap
233233
.get(aRole);

0 commit comments

Comments
 (0)