Add ValueType feature

Allow Parser.parse() to accept an EnumSet of ValueType so the caller
may limit the allowed value types. This is done during parse because
it can fail immediately once the type error is detected, rather than
parsing the entire input and checking on return.

Added related unit tests.

Author: dmaccormack

config/pmd-ruleset.xml

@@ -28,7 +28,11 @@
    <rule ref="category/java/bestpractices.xml/JUnit4TestShouldUseBeforeAnnotation"/>
    <rule ref="category/java/bestpractices.xml/JUnit4TestShouldUseTestAnnotation"/>
    <rule ref="category/java/bestpractices.xml/JUnitAssertionsShouldIncludeMessage"/>
+
+   <!-- disable
    <rule ref="category/java/bestpractices.xml/JUnitTestContainsTooManyAsserts"/>
+   -->
+
    <rule ref="category/java/bestpractices.xml/JUnitTestsShouldIncludeAssert"/>
    <rule ref="category/java/bestpractices.xml/JUnitUseExpected"/>
    <rule ref="category/java/bestpractices.xml/LooseCoupling"/>
@@ -214,7 +218,11 @@
    <rule ref="category/java/errorprone.xml/AvoidMultipleUnaryOperators"/>
    <rule ref="category/java/errorprone.xml/AvoidUsingOctalValues"/>
    <rule ref="category/java/errorprone.xml/BadComparison"/>
+
+   <!-- way too many false positives
    <rule ref="category/java/errorprone.xml/BeanMembersShouldSerialize"/>
+   -->
+
    <rule ref="category/java/errorprone.xml/BrokenNullCheck"/>
    <rule ref="category/java/errorprone.xml/CallSuperFirst"/>
    <rule ref="category/java/errorprone.xml/CallSuperLast"/>

module/jsonurl-core/src/main/java/org/jsonurl/JavaValueFactory.java

@@ -19,6 +19,7 @@
 
 import java.util.ArrayList;
 import java.util.Collections;
+import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -82,16 +83,6 @@ public Number getNumber(NumberText text) {
      */
     public static final Map<String,Object> EMPTY = Collections.emptyMap();
 
-    @Override
-    default Class<?> getObjectClass() {
-        return Map.class;
-    }
-
-    @Override
-    default Class<?> getArrayClass() {
-        return List.class;
-    }
-
     @Override
     default Object getEmptyComposite() {
         return EMPTY;
@@ -140,12 +131,38 @@ default Boolean getFalse() {
     default String getString(CharSequence s, int start, int stop) {
         return toJavaString(s, start, stop);
     }
-    
+
     @Override
     default String getString(String s) {
         return s;
     }
 
+    @Override
+    default boolean isValid(EnumSet<ValueType> types, Object value) {
+        if (isNull(value)) {
+            return types.contains(ValueType.NULL);
+        }
+        if (isEmpty(value)) {
+            return ValueType.containsComposite(types);
+        }
+        if (value instanceof String) {
+            return types.contains(ValueType.STRING);
+        }
+        if (value instanceof Number) {
+            return types.contains(ValueType.NUMBER);
+        }
+        if (value instanceof Boolean) {
+            return types.contains(ValueType.BOOLEAN);
+        }
+        if (value instanceof List) {
+            return types.contains(ValueType.ARRAY);
+        }
+        if (value instanceof Map) {
+            return types.contains(ValueType.OBJECT);
+        }
+        return false;
+    }
+
     /**
      * Get a java.lang.String from a java.lang.CharSequence
      * @param cs input

module/jsonurl-core/src/main/java/org/jsonurl/JsonUrl.java

@@ -56,7 +56,8 @@ private static final int percentDecode(
                 int len) {
 
             if (off + 2 > len) {
-                return 0;
+                // return 0;
+                throw new SyntaxException(ERR_MSG_BADPCTENC, off);
             }
 
             int c1 = hexDecode(s.charAt(off));

module/jsonurl-core/src/main/java/org/jsonurl/JsonUrlTextAppender.java

@@ -36,7 +36,7 @@ public abstract class JsonUrlTextAppender<A extends Appendable, R>
     /**
      * Destination, provided in constructor.
      */
-    protected final A out; // NOPMD - not a bean
+    protected final A out;
 
     /**
      * Create a new JsonUrlTextAppender.