-
Notifications
You must be signed in to change notification settings - Fork 9
Decom view.jquery.com and other view sites #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@brianwarner The following stage domains may be removed from DNS, and anywhere else (e.g. Cloudflare config or for future certificates):
It seems these are already unavailable, but just in case there's any references left, feel free to remove these without redirect since they were only for our own internal use during development. |
OK. The redirects are in place.
@brianwarner To make this live the view domains can be updated in Cloudflare to point to wp-01.ops instead of view-01.ops. |
Thanks @Krinkle, I checked and the The other changes are in place now. |
@Krinkle I thought we were going to redirect to GitHub, not the releases site? The view sites provided access to the file structure at specific tags & branches so it's closer to what GitHub provides than to what's on the releases site. |
@mgol Yeah, I thought maybe the releases site is more useful since that's where you can actually download the builds similar to what the view site was producing (in addition to serving source code as-is). Looking at access logs, there isn't much. But the little that is there, seems to mostly be to files in It's hard to know what people expect from it exactly, and I don't remember what if anything it was originally promoted for. When looking at the GitHub repo, it seems there are a lot of steps and thinking involved in order to navigate and find your way to the jQuery CDN (without getting side-tracked into anti-patterns like cloning Git, or hotlinking GitHub, or referencing third-party npm mirrors). On the other hand, if we link to the CDN viewer and someone wants the source code instead, that seems like an easier problem to solve manually. Does this sound compelling? I don't mind changing the redirects though. I have a patch ready to go locally that changes the redirects to GitHub instead. Let me know what you think after reading this! |
Hmm, you might be right with regards to the dist files. Are we redirecting specific files or just the whole domains, though? If we also redirect files then at least the non-dist ones would be the most useful to redirect to an equivalent URL on GitHub. That said, I'm not 100% convinced this is necessary so I'm fine with you going with your gut feeling here. :) |
Before we do, let's check traffic logs for any major constumers we could give a nice heads up. Then redirect the URLs to one of releases.jquery.com, the project home page, or the GitHub repo.
/cc @jorydotcom @mgol
The text was updated successfully, but these errors were encountered: