Give up on previous approach; break jsdom sandbox

Fixing one test seemed to break another; I'm not certain that IndexedDB's expected timing and order of operations can be made to work within the microtask queue.

Instead, break jsdom's sandbox so that we can use Node.js's setImmediate after all:

- jsdom/jsdom#2729
- scala-js/scala-js-macrotask-executor#17

Author: joshkel

src/FDBDatabase.ts

@@ -10,7 +10,7 @@ import {
 import fakeDOMStringList from "./lib/fakeDOMStringList";
 import FakeEventTarget from "./lib/FakeEventTarget";
 import ObjectStore from "./lib/ObjectStore";
-import { queueTask, queueTaskForNextEventLoop } from "./lib/scheduling";
+import { queueTask } from "./lib/scheduling";
 import { FakeDOMStringList, KeyPath, TransactionMode } from "./lib/types";
 import validateKeyPath from "./lib/validateKeyPath";
 
@@ -55,7 +55,7 @@ const closeConnection = (connection: FDBDatabase) => {
         );
     } else {
         // Wait for the next event loop to give transactions time to finish.
-        queueTaskForNextEventLoop(() => {
+        queueTask(() => {
             closeConnection(connection);
         });
     }

src/FDBFactory.ts

@@ -6,7 +6,7 @@ import Database from "./lib/Database";
 import enforceRange from "./lib/enforceRange";
 import { AbortError, VersionError } from "./lib/errors";
 import FakeEvent from "./lib/FakeEvent";
-import { queueTask, queueTaskForNextEventLoop } from "./lib/scheduling";
+import { queueTask } from "./lib/scheduling";
 
 const waitForOthersClosedDelete = (
     databases: Map<string, Database>,
@@ -19,7 +19,7 @@ const waitForOthersClosedDelete = (
     });
 
     if (anyOpen) {
-        queueTaskForNextEventLoop(() =>
+        queueTask(() =>
             waitForOthersClosedDelete(databases, name, openDatabases, cb),
         );
         return;
@@ -229,9 +229,7 @@ class FDBFactory {
         const request = new FDBOpenDBRequest();
         request.source = null;
 
-        // In order for delete requests to be processed in the proper order (see
-        // delete-request-queue.js), this must wait until the next event loop.
-        queueTaskForNextEventLoop(() => {
+        queueTask(() => {
             const db = this._databases.get(name);
             const oldVersion = db !== undefined ? db.version : 0;
 
@@ -280,10 +278,7 @@ class FDBFactory {
         const request = new FDBOpenDBRequest();
         request.source = null;
 
-        // Since deletion has to happen at next event loop (see deleteDatabase),
-        // opening has to happen at next event loop for
-        // idbfactory-open-error-properties.js to pass.
-        queueTaskForNextEventLoop(() => {
+        queueTask(() => {
             openDatabase(
                 this._databases,
                 name,

src/FDBTransaction.ts

@@ -10,7 +10,7 @@ import {
 import fakeDOMStringList from "./lib/fakeDOMStringList";
 import FakeEvent from "./lib/FakeEvent";
 import FakeEventTarget from "./lib/FakeEventTarget";
-import { queueTask, queueTaskForNextEventLoop } from "./lib/scheduling";
+import { queueTask } from "./lib/scheduling";
 import {
     EventCallback,
     FakeDOMStringList,
@@ -150,9 +150,6 @@ class FDBTransaction extends FakeEventTarget {
             operation,
             request,
         });
-        if (!this._started) {
-            queueTask(() => this._start());
-        }
 
         return request;
     }
@@ -238,18 +235,12 @@ class FDBTransaction extends FakeEventTarget {
 
         // Check if transaction complete event needs to be fired
         if (this._state !== "finished") {
-            this._started = false;
-            // Either aborted or committed already
-            queueTaskForNextEventLoop(() => {
-                if (!this._started && this._state !== "finished") {
-                    this._state = "finished";
-
-                    if (!this.error) {
-                        const event = new FakeEvent("complete");
-                        this.dispatchEvent(event);
-                    }
-                }
-            });
+            this._state = "finished";
+
+            if (!this.error) {
+                const event = new FakeEvent("complete");
+                this.dispatchEvent(event);
+            }
         }
     }
 

src/lib/scheduling.ts

@@ -1,11 +1,13 @@
-export function queueTask(fn: () => void) {
-    queueMicrotask(fn);
-}
-
-export function queueTaskForNextEventLoop(fn: () => void) {
-    if ("setImmediate" in globalThis) {
-        (globalThis as any).setImmediate(fn);
+function getSetImmediateFromJsdom() {
+    if (typeof navigator !== "undefined" && /jsdom/.test(navigator.userAgent)) {
+        const outerRealmFunctionConstructor = Node.constructor as any;
+        return new outerRealmFunctionConstructor("return setImmediate")();
     } else {
-        setTimeout(fn, 0);
+        return undefined;
     }
 }
+
+export const queueTask: (fn: () => void) => void =
+    globalThis.setImmediate ||
+    getSetImmediateFromJsdom() ||
+    ((fn: () => void) => setTimeout(fn, 0));