Skip to content

Commit 71e63fa

Browse files
committed
all: use time.Time.Equal instead of == in some tests
(Found by making time.Time uncomparable and rerunning std tests locally.) Change-Id: I4fa6fb0ba7334965362387e2f6541c17a27ac3aa Reviewed-on: https://go-review.googlesource.com/42616 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Martin Möhrmann <moehrmann@google.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
1 parent b8c7fdd commit 71e63fa

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/cmd/go/go_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -3090,7 +3090,7 @@ func TestGoTestRaceInstallCgo(t *testing.T) {
30903090
tg.run("test", "-race", "-i", "runtime/race")
30913091
new, err := os.Stat(cgo)
30923092
tg.must(err)
3093-
if new.ModTime() != old.ModTime() {
3093+
if !new.ModTime().Equal(old.ModTime()) {
30943094
t.Fatalf("go test -i runtime/race reinstalled cmd/cgo")
30953095
}
30963096
}

src/net/dial_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ func TestDialerPartialDeadline(t *testing.T) {
529529
if err != tt.expectErr {
530530
t.Errorf("#%d: got %v; want %v", i, err, tt.expectErr)
531531
}
532-
if deadline != tt.expectDeadline {
532+
if !deadline.Equal(tt.expectDeadline) {
533533
t.Errorf("#%d: got %v; want %v", i, deadline, tt.expectDeadline)
534534
}
535535
}

src/net/dnsclient_unix_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ func TestRetryTimeout(t *testing.T) {
784784
return nil, poll.ErrTimeout
785785
}
786786

787-
if deadline == deadline0 {
787+
if deadline.Equal(deadline0) {
788788
t.Error("deadline didn't change")
789789
}
790790

0 commit comments

Comments
 (0)